Shape Up #1 - e2e tests #2099
Merged
Shape Up #1 - e2e tests #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-2099.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
shapeup1-workflows-ui
branch
from
7e32a36
to
5ffaa37
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-tests
branch
from
880850e
to
dbd5403
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-workflows-ui
branch
from
7988749
to
7b4808f
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-tests
branch
from
dbd5403
to
75981a5
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-tests
branch
from
75981a5
to
1d6faf4
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-workflows-ui
branch
from
f4cd85c
to
484f2c5
Compare
lorenzo-cavazzi
force-pushed
the
shapeup1-tests
branch
from
1d6faf4
to
afe0d63
Compare
andre-code
requested changes
Nov 3, 2022
| @@ -574,7 +577,7 @@ function WorkflowDetailVisualizer({ | |||
| return (<div className="workflows-detail-table"> | |||
| <Row> | |||
| <WorkflowVisualizerSimpleBox title="Inputs"> | |||
| <VisualizerCommandEntities data={details.inputs} expanded={expanded} | |||
| <VisualizerCommandEntities data-cy="AAA" data={details.inputs} expanded={expanded} | |||
There was a problem hiding this comment.
What means AAA? could we use a more intuitive variable here?
There was a problem hiding this comment.
Oh, that slipped in! It was a test I forgot to clean up 🤦 Thanks for spotting it!
| getWorkflows(resultFile = "workflows/workflows-list-links-mappings.json") { | ||
| cy.intercept( | ||
| "/ui-server/api/renku/*/workflow_plans.list?*", | ||
| { fixture: resultFile } |
There was a problem hiding this comment.
Could you please use this.useMockedData to indicate if the mocked file is used or not, so far we have not implemented the switch between mocked or not but we prefer to write the test including that variable to ease the transition.
const fixture = this.useMockedData ? { fixture: resultFile } : undefined;
|
Thank you for the review! I fixed the 2 points you pointed out |
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
lorenzo-cavazzi
added a commit
that referenced
this pull request
Nov 4, 2022
lorenzo-cavazzi
added a commit
that referenced
this pull request
Nov 4, 2022
ciyer
pushed a commit
that referenced
this pull request
Nov 4, 2022
re: https://github.com/SwissDataScienceCenter/renku-rfc/blob/e2d4a6ba02b6ec51914f35e83370ae15537e72a4/feature-pitches/001-project-workflows-ui-view/001-project-workflows-ui-view.md (#2041) (#2050) (#2065) (#2071) (#2082) (#2087) (#2092) (#2102) (#2105) (#2099) Co-authored-by: Andrea Cordoba <43388408+andre-code@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covering the basic workflows functionalities with e2e tests
/deploy renku-core=develop renku=000-fix-acceptance-tests-after-changing-gitlab-url #persist extra-values=gateway.gitlabUrl=https://gitlab.dev.renku.ch/