Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch KG project data and consider switching to that for getting descriptions and avatars #2337

Closed
lorenzo-cavazzi opened this issue Jan 31, 2023 · 0 comments · Fixed by #2414
Assignees

Comments

@lorenzo-cavazzi
Copy link
Member

Description

KG has already implemented a solution for getting the project data and metadata from a "project" endpoint.
We should invoke that when we load a project and store the data into a new slice (API reference).
ℹ️ This is the only mandatory step for this issue, and we want to add that because KG will soon start keeping track of the last accesses to projects to delete obsolete metadata.

After this step, we should explore the possibility to use those data. The 2 most interesting parts are:

  • Description: this is already added at creation time through renku-core. We should:
    • use the POST /renku/project.edit endpoint to edit the project description also from the project settings page (API reference)
    • verify how quickly that information is updated on KG (do we get the new description if we invoke the KG project API immediately after modifying it? how long does it take re-indexing in this specific case?)
    • If that's slow, verify using the renku-core API to fetch that property (API reference)
  • Avatars: we should have support soon for that on renku core. The pattern would be similar to the one described above. Verify it's feasible and consider creating a follow-up issue.
  • Other properties: do they come from the KG or are those taken directly from GitLab? In the second case, we can consume them right away and start phasing out GitLab for that... Verify with KG team this info, and create follow-up issue where necessary
@lorenzo-cavazzi lorenzo-cavazzi converted this from a draft issue Jan 31, 2023
ciyer pushed a commit that referenced this issue Mar 10, 2023
ciyer pushed a commit that referenced this issue Mar 10, 2023
ciyer pushed a commit that referenced this issue Mar 13, 2023
* refactor: extract ProjectPageTitle component
ciyer pushed a commit that referenced this issue Mar 14, 2023
* refactor: extract ProjectPageTitle component
@lorenzo-cavazzi lorenzo-cavazzi moved this from Todo 📌 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Mar 15, 2023
@ciyer ciyer moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Mar 20, 2023
@github-project-automation github-project-automation bot moved this from Review 🔎 to Done ✅ in UI Sprints - DEPRECATED Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants