Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-invoke the config.show API when changing reference on the Start session page #2876

Closed
lorenzo-cavazzi opened this issue Nov 1, 2023 · 0 comments · Fixed by #2947
Closed
Assignees
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Motivation

When renku-core supports passing references to the GET /config.show endpoint (see SwissDataScienceCenter/renku-python#3649), we should update the code to start sessions so that selecting a new branch/commit also triggers a new query to update the config for the project.

Proposal

It should be easy once we can pass the references to the endpoint as a query parameter branch=<commit-sha>.
Remember to remove the logic to query the specific file from GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants