Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects search page should be finer-grained #377

Closed
ciyer opened this issue Feb 6, 2019 · 2 comments
Closed

Projects search page should be finer-grained #377

ciyer opened this issue Feb 6, 2019 · 2 comments
Assignees
Milestone

Comments

@ciyer
Copy link
Contributor

ciyer commented Feb 6, 2019

The project search page currently just offers search. Instead, it should offer 3 options in tabs: Yours, Starred, Search.

The behavior of Yours and Starred should be similar to the landing page and show projects where the user is a a member or has starred, respectively. Search should be where the current functionality of the projects page goes.

Details

Each tab can, but does not need to have its own URL. If it is easier to use the browser to track the state, do that, if it is easier to track the state of which tab is displayed in redux, that is also fine.

In the first case, then the search URL in quick-nav bar will need to be updated. In the latter case, If a search query is provided, then the active tab should be the search tab, otherwise the Yours tab.

Current behavior is that clicking once on the projects top-nav shows an empty page, waiting for input, clicking twice runs the search with empty input. It should either always run the search or never.

Mockup

image

@rokroskar
Copy link
Member

hasn't this been done? can the issue be closed?

@ciyer
Copy link
Contributor Author

ciyer commented Mar 5, 2019

Yes, I had moved it to the "Done" column in our project board and assumed that that closes it, but apparently not.

@ciyer ciyer closed this as completed Mar 5, 2019
@ciyer ciyer added this to the 0.4.1 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants