Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickNav jump improvements and support for searching for projects #366

Merged
merged 4 commits into from
Feb 7, 2019

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 8, 2019

  • The QuickNav jump function is restricted to member and starred projects. These are cached, so display of results is immediate.
  • QuickNav also allows searching for projects.

Fix #353.

@ciyer ciyer force-pushed the 353-quick-nav branch 6 times, most recently from b284307 to 1296c37 Compare January 10, 2019 16:01
@ciyer ciyer force-pushed the 353-quick-nav branch 3 times, most recently from 1b162a2 to c036996 Compare January 29, 2019 10:35
@ciyer ciyer changed the title WIP: Quick Nav Improvments WIP: QuickNav should support searching for projects Jan 29, 2019
@ciyer ciyer changed the title WIP: QuickNav should support searching for projects WIP: QuickNav support for searching for projects Jan 29, 2019
@ciyer ciyer changed the title WIP: QuickNav support for searching for projects WIP: QuickNav jump improvements and support for searching for projects Jan 29, 2019
@ciyer ciyer force-pushed the 353-quick-nav branch 3 times, most recently from 583185c to a518cd2 Compare January 29, 2019 15:37
@ciyer ciyer changed the title WIP: QuickNav jump improvements and support for searching for projects QuickNav jump improvements and support for searching for projects Jan 29, 2019
@rokroskar
Copy link
Member

Tested, seems to work as advertised. A few comments/concerns.

  1. there seems to be an overload of buttons:

image

The New Project and Search Buttons are almost on top of each other. Here I'm almost wishing for some central column of elements more evenly spaced (e.g. github does it this way). With the left-align it looks strange even on my 13" laptop:

image

Do we need the New Project button? I think the + drop-down is enough. Still, I think if the search bar is the only element on the page it needs to be a bit bigger/wider (ok, maybe this PR is not about styling).

  1. clicking on Projects on the top navbar twice gives me the full project list (i.e. it seems to be the equivalent of clicking the search button without a search text).

Unrelated: I noticed now that the drop down items in the + drop down are not using the correct elements (compare with the rightmost drop-down).

@ciyer
Copy link
Contributor Author

ciyer commented Feb 5, 2019

I don't really like the way this looks either, but I think it is a big usability improvement over the status quo. I think the better solution is to have 3 tabs on the project page: Yours, Starred, Explore (Yours would be projects where you are a dev or higher).

I think the New Project button is important for usability, esp for new users, and the tabs would resolve the aesthetic issues with the current solution.

@ableuler
Copy link
Contributor

ableuler commented Feb 6, 2019

clicking on Projects on the top navbar twice gives me the full project list (i.e. it seems to be the equivalent of clicking the search button without a search text).

Noticed the same, not sure if this is a feature or a bug...

I agree with @ciyer that the caching of "your projects" and the ability to quickly switch between them adds some value. I would suggest to merge this PR and then move the search functionality into a separate tab later. Actually, the landing page is very close to what I would imagine the project page to look like. screenshot 2019-02-06 at 16 37 15

While moving the project search into a separate tab, It would also be nice to make it a bit more powerful, for example enable searching for all projects of a given user (although there doesn't seem to be a straighforward api for this: https://gitlab.com/gitlab-org/gitlab-ce/issues/23185).

@rokroskar
Copy link
Member

Ah yes agreed - apologies, I thought I approved this earlier. Can we make an issue for these improvements?

@ableuler
Copy link
Contributor

ableuler commented Feb 6, 2019

Ah yes agreed - apologies, I thought I approved this earlier. Can we make an issue for these improvements?

I think #377 is about this.

@ciyer ciyer merged commit f80dd69 into master Feb 7, 2019
@ciyer ciyer deleted the 353-quick-nav branch February 7, 2019 08:16
@ciyer ciyer added this to the 0.3.1 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants