-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickNav jump improvements and support for searching for projects #366
Conversation
b284307
to
1296c37
Compare
1b162a2
to
c036996
Compare
583185c
to
a518cd2
Compare
Tested, seems to work as advertised. A few comments/concerns.
The Do we need the
Unrelated: I noticed now that the drop down items in the |
I don't really like the way this looks either, but I think it is a big usability improvement over the status quo. I think the better solution is to have 3 tabs on the project page: Yours, Starred, Explore (Yours would be projects where you are a dev or higher). I think the New Project button is important for usability, esp for new users, and the tabs would resolve the aesthetic issues with the current solution. |
Noticed the same, not sure if this is a feature or a bug... I agree with @ciyer that the caching of "your projects" and the ability to quickly switch between them adds some value. I would suggest to merge this PR and then move the search functionality into a separate tab later. Actually, the landing page is very close to what I would imagine the project page to look like. While moving the project search into a separate tab, It would also be nice to make it a bit more powerful, for example enable searching for all projects of a given user (although there doesn't seem to be a straighforward api for this: https://gitlab.com/gitlab-org/gitlab-ce/issues/23185). |
Ah yes agreed - apologies, I thought I approved this earlier. Can we make an issue for these improvements? |
I think #377 is about this. |
Fix #353.