Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a meaningful error when project can't be created #636

Closed
pameladelgado opened this issue Oct 1, 2019 · 3 comments · Fixed by #656
Closed

Display a meaningful error when project can't be created #636

pameladelgado opened this issue Oct 1, 2019 · 3 comments · Fixed by #656
Assignees
Milestone

Comments

@pameladelgado
Copy link
Contributor

Description
When user can't create new projects on Gitlab, Renku displays error namespace: is not valid

To Reproduce
Steps to reproduce the behaviour:

  1. Go to https://dev.renku.ch/ or any other Renku deployment and login with a user that doesn't have the rights to create new projects
  2. Go to Project --> New Project
  3. See error in screenshots, project can't be created because user can't create new projects on gitlab but error message is incorrect namespace: is not valid

Expected behavior
A more meaningful error should be displayed user reached the project limit, see second screenshot.

Screenshots
Error message when creating a new project on Renku:
limit-namespace-display

Warning message on Gitlab:
limit-gitlab-error

Additional information
This happens in any Renku deployment.

@ciyer ciyer added this to the sprint-2019-10-03 milestone Oct 1, 2019
@lorenzo-cavazzi
Copy link
Member

The error message you see is actually very close to the one currently returned by the POST /projects GitLab API

{"message":{"namespace":["is not valid"],"limit_reached":[]}}

We currently filter error messages without explanation, this is why no reference to the reached limit is displayed. I suggest to do as follows:

  • Display all error message, even without explanation. In this case it will display something like
    Screenshot_20191029_144107
  • If this is a common error, we can easily display something more informative to the user. I'll create a PR with a proposed solution

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Oct 29, 2019
@pameladelgado
Copy link
Contributor Author

pameladelgado commented Oct 29, 2019

Ok I see.
Although it would be nice to get a meaningful error for the user, I understand that it is not practical to translate all GitLab errors into user friendly feedback.
For me, having all the errors displayed including the ones without explanation is better than filtering them. For instance, limit_reached would have definitely make me think that something else than the gitlab version was the cause of the problem.

In addition to your suggestion I think we could specify where/when the error comes from. In this case is Gitlab and not the user or Renku. For errors in GitLab we could maybe even refer the users to test creating/forking a project in GitLab to see more details.

Thanks for looking into this issue.

@lorenzo-cavazzi
Copy link
Member

You are right, handling all the errors is practically impossible, but we can still display something more user-friendly for the most common cases.

I am not sure if we want to suggest users trying out things in GitLab for debugging errors. Anyway, the process of creating a new project in the UI will change soon as part of SwissDataScienceCenter/renku#611 and we will make sure to make errors more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants