Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display of images specified with relative path in readme files #667

Closed
vfried opened this issue Nov 1, 2019 · 1 comment · Fixed by #1008
Closed

Display of images specified with relative path in readme files #667

vfried opened this issue Nov 1, 2019 · 1 comment · Fixed by #1008
Milestone
sprint-2020-07-31

Comments

@vfried
Copy link
Contributor

vfried commented Nov 1, 2019 •
edited
Loading

There is no image preview for markdown files like:

https://renkulab.io/gitlab/bst262-2019/problem1

Image from gitlab:
image
@ciyer ciyer changed the title Add image preview to readme files Display of images specified with relative path in readme files Nov 5, 2019
@ciyer
Copy link
Contributor

ciyer commented Nov 5, 2019

The problem is the path to the image. In the README above, the path is specified as a relative path and doesn't resolve correctly in the Renku UI. Image preview does work for image paths that are fully specified. So that is a workaround, but I agree that it should work the same in Renku as in GitLab.

@ciyer ciyer added this to the sprint-2020-07-31 milestone Jul 29, 2020
@ciyer ciyer mentioned this issue Jul 29, 2020
Closed
@vfried vfried mentioned this issue Aug 13, 2020
Merged
vfried added a commit that referenced this issue Sep 7, 2020
@vfried
feat: display of relative paths in markdown and improvement in file p…
b945402 
…review in markdown (#1008)(#941)(#667)

* feat: display of relative paths in markdown and improvement in file preview

* fixes and improvements

* fixes in relative paths

* fixes and test
ciyer pushed a commit that referenced this issue Sep 9, 2020
@vfried @cramakri
feat: display of relative paths in markdown and improvement in file p…
cf05ebe 
…review in markdown (#1008)(#941)(#667)

* feat: display of relative paths in markdown and improvement in file preview

* fixes and improvements

* fixes in relative paths

* fixes and test

(cherry picked from commit b945402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint-2020-07-31
2 participants
@ciyer @vfried