feat: add maintenace page #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
force-pushed
the
894-maintenace-page
branch
from
6bc45d2
to
bdbf359
Compare
lorenzo-cavazzi
changed the title
ciyer
requested changes
Apr 14, 2020
helm-chart/renku-ui/values.yaml
Outdated
| @@ -62,6 +62,9 @@ templatesRepository: | |||
| url: https://github.com/SwissDataScienceCenter/renku-project-template | |||
| ref: 0.1.9 | |||
|
|
|||
| # any string here will enable the maintenance page and be added on it as an info | |||
There was a problem hiding this comment.
Maybe clarify: Any string here, other than 'false', will ...
There was a problem hiding this comment.
good point! I added also an extra line about true
run-telepresence.sh
Outdated
| @@ -75,7 +75,8 @@ tee > ./public/config.json << EOF | |||
| "SENTRY_URL": "${SENTRY_URL}", | |||
| "SENTRY_NAMESPACE": "${SENTRY_NAMESPACE}", | |||
| "RENKU_TEMPLATES_URL": "https://github.com/SwissDataScienceCenter/renku-project-template", | |||
| "RENKU_TEMPLATES_REF": "master" | |||
| "RENKU_TEMPLATES_REF": "master", | |||
| "MAINTENANCE": "true" | |||
There was a problem hiding this comment.
This is probably just for debugging this PR and should be removed now.
There was a problem hiding this comment.
oh right, that accidentally slipped in!
| @@ -44,6 +44,10 @@ spec: | |||
| value: {{ required "templateRepository.url must be specified, e.g., https://github.com/repos/SwissDataScienceCenter/renku-project-template" .Values.templatesRepository.url | quote }} | |||
| - name: RENKU_TEMPLATES_REF | |||
| value: {{ required "templateRepository.ref must be specified, e.g., master" .Values.templatesRepository.ref | quote }} | |||
| {{- if .Values.maintenance }} | |||
| - name: MAINTENANCE | |||
| value: {{ .Values.maintenance | default (printf "true") | quote }} | |||
There was a problem hiding this comment.
Shouldn't the default be false?
lorenzo-cavazzi
force-pushed
the
894-maintenace-page
branch
from
4b0100c
to
c1b8fac
Compare
ciyer
approved these changes
Apr 14, 2020
pameladelgado
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a maintenance page to be used during renkulab maintenances when important components are not available (e.g. Keycloack, GitLab, ...). This prevents any API call.
The maintenance page is piloted by
ui.maintenancein the values files or theMAINTENANCEenvironment variable in the pod (the latter is created from the former).By default
ui.maintenance: false. It can be set totrueor to any other string that will be used as a message to display on the maintenance page.TEST
Preview available here: https://lorenzotest.dev.renku.ch/
Feel free to modify the values while testing (the easiest is modifying the
MAINTENANCEUI pod env variable from rancher).This is the maintenance page with the standard message:
fix #894