perf: query 100 projects instead of 20 #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should query for 100 projects per page instead of 20 to prevent unnecessary queries.
ciyer
approved these changes
Jul 20, 2020
Closed
ciyer
pushed a commit
that referenced
this pull request
Sep 9, 2020
Change the default per_page parameter from 20 to 100 when invoking the GET /projects endpoint from GitLab to prevent unnecessary queries. (cherry picked from commit c6fced4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should query for 100 projects per page instead of 20 to prevent unnecessary multiple queries.
Not a big change tbf, but I noticed that the current limit per page is pretty low and we end up making way more queries than necessary.