-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Inline math formulas (#1600) #1622
Conversation
You can access the deployment of this PR at https://renku-ci-ui-1622.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline looks good, but there are still a few problems with the formulas.
In the example you linked, the second formula is the following
It's rendered correctly on GitLab
but it's not in our UI (look at the extra <=ft
and right
)
P.S: I'm not sure if it's easy to fix this using replace
or we should rather give a look at other alternative libraries for rendering the formulas.
Many thanks for the review @lorenzo-cavazzi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tearing down the temporary RenkuLab deplyoment for this PR. |
$` and `$
Project example:
https://renku-ci-ui-1622.dev.renku.ch/projects/lorenzo.cavazzi.tech/math-example
/deploy
Closes #1600