Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE BRANCH - KG-powered search #1894

Merged
merged 13 commits into from
Jan 9, 2023
Merged

FEATURE BRANCH - KG-powered search #1894

merged 13 commits into from
Jan 9, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jun 10, 2022

✨ PR of the Cross Entity Search (CES). ✨

Cross Entity Search (CES) is a new way to search for entities in the Renku application. Previously the information shown in the list of projects or datasets came from Gitlab, core-services and the Knowledge Graph, CES only shows what exists in the Knowledge Graph. We integrated in one page how to search, filter and sort entities like Projects and datasets, in the future we will integrate workflows as well.

Since the information shown belongs to what exists in Knowledge Graph (KG), we include an option to activate KG to the projects and datasets that have those projects.

🏁 Goals of this new feature:

  1. To activate KG to all pending projects from the same interface.
    For this, once authenticated the user will find in the home page or in the search engine page an alert indicating how many projects are pending to be activated and the link to the page to activate them.

kg-search activate projects

  1. Once the projects are activated, the user will be able to search for these entities and all existing entities. The entity search has filters for:
  • type of entities (project, datasets)
  • by author (all or only owned by me)
  • by visibility (public, private, internal)
  • creation date

kg-search filters 2

/deploy renku=000-cypres-tests-new-search #persist #cypress
fix #2109
fix SwissDataScienceCenter/renku/issues/1924
Closes #2216

@andre-code andre-code temporarily deployed to renku-ci-ui-1894 June 10, 2022 09:19 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1894.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-1894 August 8, 2022 13:07 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 August 8, 2022 13:29 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 August 12, 2022 07:47 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 September 13, 2022 11:58 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 September 14, 2022 19:27 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 September 19, 2022 10:43 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 September 19, 2022 11:25 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 September 19, 2022 11:50 Inactive
@lorenzo-cavazzi lorenzo-cavazzi changed the title Kg search FEATURE BRANCH - KG-powered search Oct 7, 2022
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 12, 2022 12:53 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 12, 2022 14:34 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 12, 2022 14:44 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 13, 2022 09:05 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 14, 2022 08:03 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 14, 2022 10:48 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 14, 2022 11:01 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 October 14, 2022 11:05 Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well!
Just a tiny detail: the link to the documentation page about KG in the "inactive projects" page leads to a 404 page. Could you double-check the link?

Screenshot_20230106_140143

@ciyer ciyer dismissed their stale review January 6, 2023 14:08

Out of date

@andre-code andre-code temporarily deployed to renku-ci-ui-1894 January 6, 2023 14:22 — with GitHub Actions Inactive
@andre-code
Copy link
Contributor Author

This works well! Just a tiny detail: the link to the documentation page about KG in the "inactive projects" page leads to a 404 page. Could you double-check the link?

thanks @lorenzo-cavazzi for your review.
Yes, the link has changed, I updated it in the last commit.

@andre-code andre-code temporarily deployed to renku-ci-ui-1894 January 6, 2023 15:19 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1894 January 6, 2023 15:37 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 6, 2023 15:44 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 6, 2023 23:28 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to me! 🚀

I added a couple of commits to:

  • Adjust sorting (names and order in the dropdown menu, plus a workaround to prevent showing old projects on default searches until a KG fix is ready)
  • Use the docs link generator
  • Change the column size

It would be great if @ciyer could also give it a quick look since I added a few changes

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 7, 2023 22:58 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 08:07 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 09:15 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 09:51 — with GitHub Actions Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes work well for me!

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 12:33 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 14:41 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 15:27 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1894 January 9, 2023 16:30 — with GitHub Actions Inactive
@andre-code andre-code merged commit d3f4fe9 into master Jan 9, 2023
@andre-code andre-code deleted the kg-search branch January 9, 2023 17:21
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 9, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge kg-search UI kg-search glitches and testing UX(search): KG-based search for entities
4 participants