-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set page title to project or dataset title (#1881) #1898
Conversation
You can access the deployment of this PR at https://renku-ci-ui-1898.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition to improve SEO evaluation and also see Helmet in action, quite easy to modify the metadata. 💫
My only suggestion is to use Title Case, or capitalize only the first letter to make it easier on the eye in the browser tab and search results.
I agree that would look nicer, but the title is something that the user controls, so I want to be careful about changing the formatting without user intervention. Let me solicit some feedback from others to resolve this. |
After some discussions, we have decided to make the title:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tearing down the temporary RenkuLab deplyoment for this PR. |
Introduces changes to set the title tag as a user navigates through Renku.
closes #1881
Project
Dataset
/deploy renku=tests-ui-2.5.0 #persist