Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set page title to project or dataset title (#1881) #1898

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jun 10, 2022

Introduces changes to set the title tag as a user navigates through Renku.

  • On a project page, the title tag is the title of the project
  • On a dataset page, the title tag is the title of the dataset
  • Otherwise, the title tag is "Reproducible Data Science | Open Research | Renku"

closes #1881

Project
image

Dataset
image

/deploy renku=tests-ui-2.5.0 #persist

@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 10, 2022 16:20 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1898.dev.renku.ch

@ciyer ciyer marked this pull request as ready for review June 13, 2022 12:27
@ciyer ciyer requested a review from a team as a code owner June 13, 2022 12:27
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 13, 2022 12:27 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 13, 2022 13:27 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 14, 2022 09:42 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 14, 2022 12:05 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 14, 2022 12:11 Inactive
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to improve SEO evaluation and also see Helmet in action, quite easy to modify the metadata. 💫
My only suggestion is to use Title Case, or capitalize only the first letter to make it easier on the eye in the browser tab and search results.

@ciyer
Copy link
Contributor Author

ciyer commented Jun 15, 2022

My only suggestion is to use Title Case, or capitalize only the first letter to make it easier on the eye in the browser tab and search results.

I agree that would look nicer, but the title is something that the user controls, so I want to be careful about changing the formatting without user intervention. Let me solicit some feedback from others to resolve this.

@ciyer
Copy link
Contributor Author

ciyer commented Jun 16, 2022

Great addition to improve SEO evaluation and also see Helmet in action, quite easy to modify the metadata. 💫 My only suggestion is to use Title Case, or capitalize only the first letter to make it easier on the eye in the browser tab and search results.

After some discussions, we have decided to make the title:

[project title] • Project • [project path] • [project description, if available]
[dataset title] • Dataset • [dataset description, if available]

@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 17, 2022 10:25 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 17, 2022 11:50 Inactive
@ciyer ciyer requested a review from andre-code June 17, 2022 13:27
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 20, 2022 07:21 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 20, 2022 08:08 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 22, 2022 06:18 Inactive
andre-code
andre-code previously approved these changes Jun 22, 2022
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lokijuhy lokijuhy temporarily deployed to renku-ci-ui-1898 June 22, 2022 09:58 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 22, 2022 11:31 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 23, 2022 15:42 Inactive
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 24, 2022 11:50 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 24, 2022 13:32 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1898 June 24, 2022 15:46 Inactive
@ciyer ciyer deployed to renku-ci-ui-1898 June 24, 2022 18:20 Active
@ciyer ciyer merged commit f2286de into master Jun 24, 2022
@ciyer ciyer deleted the 1881-title-tag branch June 24, 2022 19:53
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project page title tag should include the name of the project (to display in browser tab)
5 participants