Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify start session flow (#2115) #2131

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Nov 9, 2022

PR to apply the same Auto start session flow to Start a session with options flow.

start session with options flow

Current flows to test:

  • Quick start session from project header button or project card button
  • Start session from link
  • Start session with options
  • Error starting a session (autostart, from link or with options)

Closes #2115

/deploy renku=2115-unify-start-session-flow #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 9, 2022 11:40 Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 9, 2022

You can access the deployment of this PR at https://renku-ci-ui-2131.dev.renku.ch

@andre-code andre-code changed the title WIP feat: unify start session flow (#2115) feat: unify start session flow (#2115) Nov 10, 2022
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 10, 2022 12:43 Inactive
@andre-code andre-code marked this pull request as ready for review November 10, 2022 13:00
@andre-code andre-code requested a review from a team as a code owner November 10, 2022 13:00
ciyer
ciyer previously approved these changes Nov 10, 2022
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the scenarios that you list, and it worked well in all of them! 🎉

@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 10, 2022 15:48 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 11, 2022 08:29 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 11, 2022 10:06 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 11, 2022 10:32 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 11, 2022 14:48 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 14, 2022 10:47 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 14, 2022 11:10 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 14, 2022 14:26 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 14, 2022 15:09 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 15, 2022 09:20 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2131 November 15, 2022 10:00 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2131 November 18, 2022 22:50 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2131 November 18, 2022 23:13 Inactive
@lorenzo-cavazzi lorenzo-cavazzi merged commit 7f78f0b into master Nov 19, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 2115-unify-start-session-flow branch November 19, 2022 11:18
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the start sequence for the "Start session with option" and "Start"
4 participants