-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify start session flow (#2115) #2131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can access the deployment of this PR at https://renku-ci-ui-2131.dev.renku.ch |
andre-code
force-pushed
the
2115-unify-start-session-flow
branch
from
November 10, 2022 12:36
27dc8ac
to
10015fa
Compare
andre-code
changed the title
WIP feat: unify start session flow (#2115)
feat: unify start session flow (#2115)
Nov 10, 2022
ciyer
previously approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested all the scenarios that you list, and it worked well in all of them! 🎉
lorenzo-cavazzi
force-pushed
the
2115-unify-start-session-flow
branch
from
November 18, 2022 22:50
e999be3
to
c34ca90
Compare
lorenzo-cavazzi
approved these changes
Nov 19, 2022
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to apply the same Auto start session flow to Start a session with options flow.
Current flows to test:
Closes #2115
/deploy renku=2115-unify-start-session-flow #persist