feat: add project dashboard (#2303) #2320

andre-code · 2023-01-19T17:05:14Z

Project dashboard PR.

Cases covered in this PR:

The user has no projects of its own, it must display an informative alert.

The user has projects to activate KG, must display the Warning Alert to activate the projects.
The user has no visited any project yet, it should show the button to explore other projects.

The user has visited some projects recently, it should show a maximum of 5 projects.
The user has own projects, it should not show information alert and show the View all my projects button.

Note: Here we do not cover the session view, in case the project has a running session the Connect button will be displayed instead of the play button, the session view will be implemented in #2306.

Closes #2303

/deploy renku=000-ui-dashboard #persist #cypress

RenkuBot · 2023-01-19T17:08:36Z

You can access the deployment of this PR at https://renku-ci-ui-2320.dev.renku.ch

ciyer

This looks very good! 🚀

I noticed that some of the changes made for React 18 got lost in the rebase: those should be brought back. Otherwise, I have some questions about code in a small number of places and a few wording change suggestions. But, these are all minor things, and I think this I close to being ready to merge.

ciyer · 2023-01-27T12:17:39Z

client/src/landing/Landing.test.js

@@ -24,52 +24,60 @@
 */

 import React from "react";
-import { createRoot } from "react-dom/client";
+import ReactDOM from "react-dom";


It looks like some of the changes that came from upgrading to react 18 were lost. The use of createRoot should be brought back.

ciyer · 2023-01-27T12:18:05Z

client/src/landing/Landing.test.js

    await act(async () => {
-      root.render(
+      ReactDOM.render(


Should use createRoot / root.render here.

ciyer · 2023-01-27T12:18:29Z

client/src/landing/Landing.test.js

    await act(async () => {
-      root.render(
+      ReactDOM.render(


Should use createRoot / root.render here.

ciyer · 2023-01-27T12:21:16Z

tests/cypress/support/authentication/gui_commands.ts

    cy.url().should("be.equal", Cypress.config("baseUrl"));
-    cy.get("[data-cy='username-home']").contains(`${username} @ Renku`);
+    cy.get("[data-cy='dashboard-title']").contains(`Renku Dashboard - ${user.firstname} ${user.lastname}`);


Suggested change

cy.get("[data-cy='dashboard-title']").contains(`Renku Dashboard - ${user.firstname} ${user.lastname}`);

cy.get_cy("dashboard-title").contains(`Renku Dashboard - ${user.firstname} ${user.lastname}`);

ciyer · 2023-01-27T12:23:39Z

client/src/utils/customHooks/useGetRecentlyVisitedProjects.ts

+ *  useGetRecentlyVisitedProjects.ts
+ *  hook to fetch recent visited projects
+ */
+function useGetRecentlyVisitedProjects(cantProjects: number) {


Suggested change

function useGetRecentlyVisitedProjects(cantProjects: number) {

function useGetRecentlyVisitedProjects(projectsCount: number) {

tests/cypress/e2e/local/dashboard.spec.ts

ciyer · 2023-01-27T12:27:27Z

tests/cypress/e2e/local/dashboard.spec.ts

+    cy.get_cy("inactive-kg-project-alert").should("exist");
+  });
+
+  it("user does not has own project but has visited projects", () => {


Suggested change

it("user does not has own project but has visited projects", () => {

it("user does not have own project but has visited projects", () => {

ciyer · 2023-01-27T12:28:10Z

tests/cypress/e2e/local/dashboard.spec.ts

+      });
+  });
+
+  it("user does has own projects and recently visited projects", () => {


Suggested change

it("user does has own projects and recently visited projects", () => {

it("user has own projects and recently visited projects", () => {

ciyer · 2023-01-27T12:29:05Z

client/src/features/dashboard/components/ProjectsDashboard.tsx

+  return total === 0 ?
+    <InfoAlert timeout={0}>
+      <div data-cy="project-alert" className="mb-0" style={{ textAlign: "justify" }}>
+        <h3><strong>You don’t have any project yet.</strong></h3>


I think it would be a bit better like this:

Suggested change

<h3><strong>You don’t have any project yet.</strong></h3>

<h3><strong>You do not have any projects yet.</strong></h3>

ciyer · 2023-01-27T12:31:23Z

client/src/features/dashboard/components/ProjectsDashboard.tsx

+  else {
+    projectsToShow = projects?.length > 0 ?
+      <ProjectListRows projects={projects} gridDisplay={false} />
+      : <p className="rk-dashboard-section-header">You have no current project yet</p>;


I think current is not necessary here

Suggested change

: <p className="rk-dashboard-section-header">You have no current project yet</p>;

: <p className="rk-dashboard-section-header">You do not have any recently-visited projects</p>;

andre-code · 2023-01-30T09:11:11Z

This looks very good! 🚀

I noticed that some of the changes made for React 18 got lost in the rebase: those should be brought back. Otherwise, I have some questions about code in a small number of places and a few wording change suggestions. But, these are all minor things, and I think this I close to being ready to merge.

Thanks for the review @ciyer, yes I have brought back the changes in the tests and also apply all your suggestions in the last commit, all the text changes makes sense to me.

ciyer

🎉 Ready to merge!

RenkuBot · 2023-02-01T10:06:03Z

Tearing down the temporary RenkuLab deplyoment for this PR.

Fix #2303

* feat: add entity list view (#2302)(#2307) * feat: add project dashboard (#2303) (#2320) * feat: add dataset dashboard (#2304)(#2330) * feat: add session list view in dashboard (#2305)(#2333) * feat: add get logs, stop session and link to Dashboard (#2305) (#2350) * feat: modify the internal visibility icon, redirect to the dashboard when opening sessions page to authenticated users Fix #2286 Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

andre-code temporarily deployed to renku-ci-ui-2320 January 19, 2023 17:05 — with GitHub Actions Inactive

andre-code force-pushed the 2302-entity-list-view branch from 2505531 to 87d1167 Compare January 20, 2023 07:17

Base automatically changed from 2302-entity-list-view to 2286-dashboard January 24, 2023 12:55

andre-code force-pushed the 2303-project-dashboard branch from 59a58bb to 4f72df9 Compare January 25, 2023 09:50

andre-code temporarily deployed to renku-ci-ui-2320 January 25, 2023 09:50 — with GitHub Actions Inactive

andre-code had a problem deploying to renku-ci-ui-2320 January 25, 2023 10:09 — with GitHub Actions Error

andre-code changed the title ~~WIP: add project dashboard (#2303)~~ feat: add project dashboard (#2303) Jan 25, 2023

andre-code had a problem deploying to renku-ci-ui-2320 January 25, 2023 10:10 — with GitHub Actions Failure

andre-code force-pushed the 2303-project-dashboard branch from 4f72df9 to e6133d9 Compare January 25, 2023 10:17

andre-code had a problem deploying to renku-ci-ui-2320 January 25, 2023 10:18 — with GitHub Actions Failure

andre-code marked this pull request as ready for review January 25, 2023 10:20

andre-code requested a review from a team as a code owner January 25, 2023 10:20

andre-code had a problem deploying to renku-ci-ui-2320 January 25, 2023 11:11 — with GitHub Actions Failure

andre-code had a problem deploying to renku-ci-ui-2320 January 25, 2023 12:12 — with GitHub Actions Failure

andre-code force-pushed the 2303-project-dashboard branch from e6133d9 to 4da97dc Compare January 25, 2023 12:23

andre-code temporarily deployed to renku-ci-ui-2320 January 25, 2023 12:24 — with GitHub Actions Inactive

andre-code force-pushed the 2303-project-dashboard branch from 4da97dc to c4dd73b Compare January 25, 2023 13:06

andre-code temporarily deployed to renku-ci-ui-2320 January 25, 2023 13:07 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 25, 2023 14:28 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 25, 2023 21:23 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 26, 2023 08:22 — with GitHub Actions Inactive

andre-code force-pushed the 2303-project-dashboard branch from c4dd73b to d14b5eb Compare January 26, 2023 15:13

andre-code temporarily deployed to renku-ci-ui-2320 January 26, 2023 15:14 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 06:20 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 08:01 — with GitHub Actions Inactive

andre-code force-pushed the 2286-dashboard branch from 1f20402 to aad9ce2 Compare January 27, 2023 09:07

andre-code force-pushed the 2303-project-dashboard branch from d14b5eb to c0efbe7 Compare January 27, 2023 09:19

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 09:20 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 09:51 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 11:19 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 January 27, 2023 11:21 — with GitHub Actions Inactive

ciyer requested changes Jan 27, 2023

View reviewed changes

andre-code temporarily deployed to renku-ci-ui-2320 January 30, 2023 08:58 — with GitHub Actions Inactive

andre-code force-pushed the 2303-project-dashboard branch from f1b5a3a to 92c66ba Compare January 30, 2023 09:24

andre-code temporarily deployed to renku-ci-ui-2320 January 30, 2023 09:25 — with GitHub Actions Inactive

lorenzo-cavazzi temporarily deployed to renku-ci-ui-2320 January 31, 2023 14:46 — with GitHub Actions Inactive

lorenzo-cavazzi temporarily deployed to renku-ci-ui-2320 January 31, 2023 15:09 — with GitHub Actions Inactive

lorenzo-cavazzi temporarily deployed to renku-ci-ui-2320 January 31, 2023 23:10 — with GitHub Actions Inactive

andre-code force-pushed the 2286-dashboard branch from aad9ce2 to ad5f884 Compare February 1, 2023 07:18

andre-code added 2 commits February 1, 2023 08:18

feat: add project dashboard

d1e5222

feat: use createRoot for tests, updates texts

7869adb

andre-code force-pushed the 2303-project-dashboard branch from 92c66ba to 7869adb Compare February 1, 2023 07:19

andre-code temporarily deployed to renku-ci-ui-2320 February 1, 2023 07:19 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2320 February 1, 2023 08:28 — with GitHub Actions Inactive

andre-code deployed to renku-ci-ui-2320 February 1, 2023 08:42 — with GitHub Actions Active

ciyer approved these changes Feb 1, 2023

View reviewed changes

andre-code merged commit d9725c2 into 2286-dashboard Feb 1, 2023

andre-code deleted the 2303-project-dashboard branch February 1, 2023 10:05

andre-code added a commit that referenced this pull request Feb 7, 2023

feat: add project dashboard (#2303) (#2320)

60d6c73

Fix #2303

andre-code added a commit that referenced this pull request Feb 9, 2023

feat: add project dashboard (#2303) (#2320)

76ae8f4

Fix #2303

andre-code added a commit that referenced this pull request Feb 10, 2023

feat: add project dashboard (#2303) (#2320)

f92920b

Fix #2303

andre-code added a commit that referenced this pull request Feb 13, 2023

feat: add project dashboard (#2303) (#2320)

df6e084

Fix #2303

This was referenced Feb 13, 2023

Update cross entity search to sort on 2 parameters #2335

Closed

Format description as markdown on Entity headers and Cards in the search page #2260

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add project dashboard (#2303) #2320

feat: add project dashboard (#2303) #2320

andre-code commented Jan 19, 2023 •

edited by lorenzo-cavazzi

Loading

RenkuBot commented Jan 19, 2023

ciyer left a comment

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

ciyer Jan 27, 2023

andre-code commented Jan 30, 2023

ciyer left a comment

RenkuBot commented Feb 1, 2023

	cy.get("[data-cy='dashboard-title']").contains(`Renku Dashboard - ${user.firstname} ${user.lastname}`);
	cy.get_cy("dashboard-title").contains(`Renku Dashboard - ${user.firstname} ${user.lastname}`);

	function useGetRecentlyVisitedProjects(cantProjects: number) {
	function useGetRecentlyVisitedProjects(projectsCount: number) {

	it("user does not has own project but has visited projects", () => {
	it("user does not have own project but has visited projects", () => {

	it("user does has own projects and recently visited projects", () => {
	it("user has own projects and recently visited projects", () => {

	<h3><strong>You don’t have any project yet.</strong></h3>
	<h3><strong>You do not have any projects yet.</strong></h3>

	: <p className="rk-dashboard-section-header">You have no current project yet</p>;
	: <p className="rk-dashboard-section-header">You do not have any recently-visited projects</p>;

feat: add project dashboard (#2303) #2320

feat: add project dashboard (#2303) #2320

Conversation

andre-code commented Jan 19, 2023 • edited by lorenzo-cavazzi Loading

RenkuBot commented Jan 19, 2023

ciyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andre-code commented Jan 30, 2023

ciyer left a comment

Choose a reason for hiding this comment

RenkuBot commented Feb 1, 2023

andre-code commented Jan 19, 2023 •

edited by lorenzo-cavazzi

Loading