Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unzip multiple dataset files (#2754) #2786

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Sep 6, 2023

Pull request for resolving the issue with uploading dataset files in the "Add/Modify Dataset" form.

  1. Issue with displaying subfolders in unzipped dataset files.
  • Before
    expand files Error
  • After
    expand files OK
  1. Error when sending several dataset files
  • Before
    send files error

  • After
    send files ok

Fix #2754

/deploy #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 6, 2023 08:53 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 6, 2023

You can access the deployment of this PR at https://renku-ci-ui-2786.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 7, 2023 11:17 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 7, 2023 11:51 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 7, 2023 12:16 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 7, 2023 14:08 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 11, 2023 11:09 — with GitHub Actions Inactive
@andre-code andre-code changed the title WIP fix unzip multiple dataset files (#2754) fix: unzip multiple dataset files (#2754) Sep 11, 2023
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 11, 2023 11:52 — with GitHub Actions Inactive
@andre-code andre-code marked this pull request as ready for review September 11, 2023 13:08
@andre-code andre-code requested a review from a team as a code owner September 11, 2023 13:08
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 11, 2023 13:08 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 11, 2023 14:13 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2786 September 11, 2023 14:23 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, it works well now! 🚀
Tiny fix inline (just an extra space to remove).

client/src/components/form-field/DropzoneFileUploader.js Outdated Show resolved Hide resolved
Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com>
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andre-code andre-code merged commit 0b1b6c9 into master Sep 13, 2023
14 checks passed
@andre-code andre-code deleted the 2754-fix-unzip-dataset-files branch September 13, 2023 08:13
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unzipped dataset files aren't handled correctly.
3 participants