Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): temporarily fix search bar styles #3019

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 7, 2024

Component styles which leaked global classes where used in other places; now that pages are loaded lazily, this breaks styling for components which used to rely on "hidden" global styles.

Before:
Screenshot 2024-02-07 at 10 24 46
Screenshot 2024-02-07 at 10 25 02

After:
Screenshot 2024-02-07 at 10 27 38
Screenshot 2024-02-07 at 10 29 20

@leafty leafty marked this pull request as ready for review February 7, 2024 09:30
@leafty leafty requested a review from a team as a code owner February 7, 2024 09:30
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@leafty leafty merged commit 0ea89f2 into main Feb 8, 2024
12 checks passed
@leafty leafty deleted the leafty/fix-quick-nav branch February 8, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants