feat(client): adapt session storage to repository #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-3058.dev.renku.ch |
leafty
had a problem deploying
to
renku-ci-ui-3058
GitHub Actions
Failure
ciyer
requested changes
Mar 7, 2024
Comment on lines
52
to
69
| const { minimumStorageGb, recommendedStorageGb } = | ||
| checkStorage({ lfsAutoFetch, statistics }) ?? {}; | ||
| const clampedRecommended = recommendedStorageGb | ||
| ? validateStorageAmount({ | ||
| value: recommendedStorageGb, | ||
| maxValue: currentSessionClass.max_storage, | ||
| }) | ||
| : null; | ||
| const requestedStorage = | ||
| clampedRecommended && | ||
| minimumStorageGb && | ||
| clampedRecommended > currentSessionClass.default_storage && | ||
| clampedRecommended > minimumStorageGb | ||
| ? clampedRecommended | ||
| : minimumStorageGb && | ||
| minimumStorageGb > currentSessionClass.default_storage | ||
| ? minimumStorageGb | ||
| : currentSessionClass.default_storage; |
There was a problem hiding this comment.
suggestion: extract this logic into a utility function in the sessionOptions.utils.ts file. That would allow writing a test for it; I think I understand the logic here, but a few test cases would greatly help clarify.
Co-authored-by: Chandrasekhar Ramakrishnan <ciyer@users.noreply.github.com>
leafty
had a problem deploying
to
renku-ci-ui-3058
GitHub Actions
Failure
Done in 9bbc1e2. |
ciyer
approved these changes
Mar 7, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3057.
Adds storage size computation based on GitLab statistics when starting a session.
minimumStorageisrepository_sizeorrepository_size + 2 x lfs_objects_sizeif LFS auto-fetch is enabledrecommendedStorageisminimumStorage + lfs_objects_size + 1GBorminimumStorage + 1GBif LFS auto-fetch is enabledAll sizes are rounded up to the next gigabytes and we use powers of 10 to go from bytes to GB.
The
recommendedStorageis used as a default value andminimumStorageis used to interrupt the auto-start session flow and to filter session classes.Note that statistics are available only to project members, so starting sessions on public projects could still lead to session start issues.
/deploy