Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShapeUp] feat: update start session with options #3109

Merged
merged 12 commits into from
May 2, 2024
Merged

[ShapeUp] feat: update start session with options #3109

merged 12 commits into from
May 2, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

This PR implements the second part of #3100 ,changing the "Start with options" page to include secrets.

re #3100

/deploy #notest renku=build/secrets-in-sessions renku-data-services=pitch/secret-storage secrets-storage=pitch/secret-storage extra-values=secretsStorage.encryptionKey=vMqdVXcSIwjwONvGiNE2vjzRjmi8NJ8Y9lTB8m3l/Xg=

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3109.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi changed the base branch from main to lorenzo/shape-up-secrets-in-sessions April 22, 2024 13:04
@lorenzo-cavazzi lorenzo-cavazzi changed the base branch from lorenzo/shape-up-secrets-in-sessions to lorenzo/shape-up-secrets-page April 23, 2024 11:16
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review April 24, 2024 18:49
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner April 24, 2024 18:49
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as draft April 26, 2024 08:02
Base automatically changed from lorenzo/shape-up-secrets-page to lorenzo/shape-up-secrets-in-sessions April 29, 2024 13:45
@lorenzo-cavazzi lorenzo-cavazzi force-pushed the lorenzo/shape-up-secrets-in-sessions branch from 0567824 to 4a8f2ed Compare April 29, 2024 14:07
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review May 2, 2024 07:04
ciyer
ciyer requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good! I do have some refactoring suggestions in places in the code where I thought the clarity could be improved.

client/src/features/session/components/options/SessionUserSecrets.tsx Outdated Show resolved Hide resolved
client/src/features/session/components/options/SessionUserSecrets.tsx Outdated Show resolved Hide resolved
client/src/features/session/startSessionOptionsSlice.ts Show resolved Hide resolved
client/src/features/session/components/options/SessionUserSecrets.tsx Outdated Show resolved Hide resolved
client/src/features/session/components/options/SessionUserSecrets.tsx Show resolved Hide resolved
@lorenzo-cavazzi
Copy link
Member Author

Thank you for your suggestions @ciyer
I implemented everything, except the toggle logic in the reducer -- see the motivations inline. I can still change it if you think your solution is more convenient.

@lorenzo-cavazzi lorenzo-cavazzi requested a review from ciyer May 2, 2024 12:01
ciyer
ciyer approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@lorenzo-cavazzi lorenzo-cavazzi merged commit 6c34a0d into lorenzo/shape-up-secrets-in-sessions May 2, 2024
12 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/shape-up-secrets-inject branch May 2, 2024 14:50
@RenkuBot
Copy link
Contributor

RenkuBot commented May 2, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

lorenzo-cavazzi added a commit that referenced this pull request May 2, 2024
@lorenzo-cavazzi
feat: update start session with options (#3109)
ae574f4 
re #3100
lorenzo-cavazzi added a commit that referenced this pull request May 14, 2024
@lorenzo-cavazzi
feat: add support for session secrets (#3101)
1dd1cae 
* add a new "User secrets" page (#3106)
* update the "Start session with options" page with a new section for secrets (#3109)

fix #3100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzo-cavazzi @RenkuBot @ciyer