Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support custom env variables in Renku 2.0 #3227

Merged
merged 9 commits into from
Oct 11, 2024
Merged

feat!: support custom env variables in Renku 2.0 #3227

merged 9 commits into from
Oct 11, 2024

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jul 2, 2024 •
edited
Loading

PR to Add Custom Environment Variables in the Custom Session Launcher

add custom launcher

What's Included:

  • Added support for environment variables (mount_directory, working_directory, port, gid, uid, command, args) when creating a new custom image launcher.
  • Updated existing launchers to support environment variables.
  • Updated launcher view to add environment variables.
  • Merged custom and global launcher forms.

What's Not Included ‼️:

To launch a new session with custom environment variables will be handled in a separate PR #3296.

Pitch: https://www.notion.so/renku/Support-Jupyter-free-images-2-0-a639737339754a2db10e836471890c20

/deploy

@andre-code andre-code changed the title feat: make custom image env more custom v2 [wip] feat: make custom image env more custom v2 Jul 2, 2024
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch 2 times, most recently from d684830 to c66f883 Compare July 5, 2024 07:55
@RenkuBot
Copy link
Contributor

RenkuBot commented Jul 5, 2024

You can access the deployment of this PR at https://renku-ci-ui-3227.dev.renku.ch

@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from c66f883 to e3551cf Compare July 5, 2024 12:21
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from e3551cf to 8bdf963 Compare July 5, 2024 12:41
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from 8bdf963 to ca9f1c6 Compare July 5, 2024 14:01
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from 30aac51 to 9413496 Compare August 5, 2024 08:35
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from fa845b4 to b207f09 Compare August 23, 2024 09:47
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from b207f09 to d2ab916 Compare August 23, 2024 09:58
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from 4b3de12 to ad3e021 Compare October 9, 2024 09:37
@andre-code
Copy link
Contributor Author

Thanks @leafty for your review ✨
Here the new issue: #3345
Changes included here ad3e021

@andre-code andre-code requested a review from leafty October 9, 2024 09:39
leafty
leafty approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andre-code
empty commit
9dc3619
@andre-code
feat: add/update launcher with custom environment
cc4da0e
@andre-code
feat: add custom values in add environment form for admins
fd263cd
@andre-code
add changes in refactored component after rebase main
2ba5f87
@andre-code
refactor MoreInfo
156cba0
@andre-code
improve parseJSONArray function and add constants file
2a6c048
@andre-code
apply code suggestions.
52c87fa 
- fix typo 'advance in files and variables
- reword container image description and placeholder
- change label Default URL for Default URL path
@andre-code
apply code suggestions 2.
ff21da5 
- validate that the JSON is a JSON array of strings
- return an object with error message when parse JSON array of strings
- remove submitError and only use the form validation
- display an error message when can't safeStringify the command or arg
- add ENVIRONMENT_VALUES_DESCRIPTION constant
@andre-code
apply suggestions 3:
bd9e30a 
- fix typo in form label
- use array instead of string in cx function
@andre-code andre-code force-pushed the andrea/custom-launcher-jupyter-free branch from ad3e021 to bd9e30a Compare October 11, 2024 08:27
@andre-code andre-code merged commit 69f25bb into andrea/jupyter-free-build Oct 11, 2024
18 of 19 checks passed
@andre-code andre-code deleted the andrea/custom-launcher-jupyter-free branch October 11, 2024 10:40
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

andre-code added a commit that referenced this pull request Oct 15, 2024
@andre-code
feat!: support custom env variables in Renku 2.0 (#3227)
04c6d02
andre-code added a commit that referenced this pull request Oct 17, 2024
@andre-code
feat!: support custom env variables in Renku 2.0 (#3227)
5c9eb97
@andre-code andre-code mentioned this pull request Oct 18, 2024
Merged
5 tasks
andre-code added a commit that referenced this pull request Oct 28, 2024
@andre-code
feat!: support custom env variables in Renku 2.0 (#3227)
7852b76
andre-code added a commit that referenced this pull request Nov 11, 2024
@andre-code
feat!: support custom env variables in Renku 2.0 (#3227)
e0bbbd1
andre-code added a commit that referenced this pull request Nov 12, 2024
@andre-code
feat!: add session Jupyter free images - Renku 2.0 (#3341)
4ac3ac7 
* feat!: support custom env variables in Renku 2.0  (#3227)
* feat: use data-service sessions endpoint (#3296)
* feat: show an error if the docker image identifier is invalid (#3369)

BREAKING CHANGES: requires renku-data-services >= v0.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees
No one assigned
Labels
backend changes ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre-code @RenkuBot @leafty