feat: Update redirect page styles #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3257.dev.renku.ch |
andre-code
force-pushed
the
andrea/styles-redirect-page
branch
from
c8209a9
to
9a1438d
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/styles-redirect-page
branch
from
9a1438d
to
26c8322
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
leafty
reviewed
Jul 26, 2024
|
I agree with @leafty I'm sorry @andre-code that this work would go wasted. I'm not sure I've ever seen issues/proposals for this change. |
|
Note: |
andre-code
force-pushed
the
andrea/styles-redirect-page
branch
from
26c8322
to
4b17bba
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
leafty
previously approved these changes
Oct 7, 2024
Comment on lines
+76
to
+92
| @keyframes changeBackgroundXL { | ||
| 0% { | ||
| background-image: url("./img/redirect/frog/X-Large_1.png"); | ||
| } | ||
| 25% { | ||
| background-image: url("./img/redirect/frog/X-Large_2.png"); | ||
| } | ||
| 50% { | ||
| background-image: url("./img/redirect/frog/X-Large_3.png"); | ||
| } | ||
| 75% { | ||
| background-image: url("./img/redirect/frog/X-Large_4.png"); | ||
| } | ||
| 100% { | ||
| background-image: url("./img/redirect/frog/X-Large_5.png"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Note: the images are not pre-loaded so the animation will be dependent on the fetch time from the browser. I think this is acceptable though.
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
leafty
approved these changes
Oct 8, 2024
andre-code
had a problem deploying
to
renku-ci-ui-3257
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-3257
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to apply new design for redirect page.
/deploy