design - change style for alerts #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not use text classes for the non-text icon. * Use the non-filled icons as in most v1 components. * Inherit the color used for the alert to improve contrast.
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3273
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3273.dev.renku.ch |
leafty
reviewed
Aug 19, 2024
client/src/components/Alert.jsx
Outdated
| @@ -84,11 +84,12 @@ class RenkuAlert extends Component { | |||
| } | |||
|
|
|||
| getIcon() { | |||
| const iconSize = 32; | |||
|
Opinion: I would use a rounded exclamation mark icon instead. |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-3273
GitHub Actions
Inactive
leafty
reviewed
Aug 20, 2024
| * limitations under the License. | ||
| */ | ||
|
|
||
| export const iconSize = 32; |
There was a problem hiding this comment.
Suggested change
| export const iconSize = 32; | |
| export const ALERT_ICON_SIZE = 32; |
There was a problem hiding this comment.
Ouch, I was a little sloppy 😅
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New style for alerts 💅
/deploy #notest