refactor: separate V1 cloud storage UI elements from V2 data connectors #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
ciyer/storageV2-refactor
branch
2 times, most recently
from
646d4f1
to
44cae86
Compare
ciyer
force-pushed
the
ciyer/storageV2-refactor
branch
from
701d2eb
to
ee4ca4f
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3301
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3301.dev.renku.ch |
ciyer
changed the title
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
ciyer
added a commit
that referenced
this pull request
Sep 18, 2024
ciyer
added a commit
that referenced
this pull request
Sep 19, 2024
ciyer
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation used the
CloudStorageModalcomponent, which was shared been v1 cloud storages and v2 data sources. These changes introduce a new DataConnectorModal component for use in v2 code and removes v2 references from CloudStorageModal./deploy renku=ciyer/ui-3275-data-source