-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent querying sessions launchers without project id #3313
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3313.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think the component isn't properly taking into account when session
is null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We can open a new issue for this, but the component doesn't handle properly when its props are null-ish values |
@leafty That's a fair point. Since we are fixing the component already, I've added a quick solution for handling invalid namespace/slug values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tearing down the temporary RenkuLab deplyoment for this PR. |
When starting a session, the
session_launchers
endpoints is invoked too early when the project id isn't available yet. This prevents it/deploy