Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent querying sessions launchers without project id #3313

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Sep 12, 2024

When starting a session, the session_launchers endpoints is invoked too early when the project id isn't available yet. This prevents it

image

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3313.dev.renku.ch

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think the component isn't properly taking into account when session is null.

andre-code
andre-code previously approved these changes Sep 13, 2024
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andre-code
Copy link
Contributor

Thanks to @lorenzo for fixing this!

@leafty, could you clarify what you mean by "not well handled"? I see that the buttons displayed are incorrect. Is there anything else we need to address? If so, we should consider handling those issues in a separate PR.

Screenshot 2024-09-13 at 16 08 28

@leafty
Copy link
Member

leafty commented Sep 13, 2024

Thanks to @lorenzo for fixing this!

@leafty, could you clarify what you mean by "not well handled"? I see that the buttons displayed are incorrect. Is there anything else we need to address? If so, we should consider handling those issues in a separate PR.

We can open a new issue for this, but the component doesn't handle properly when its props are null-ish values

@lorenzo-cavazzi
Copy link
Member Author

lorenzo-cavazzi commented Sep 24, 2024

We can open a new issue for this, but the component doesn't handle properly when its props are null-ish values

@leafty That's a fair point. Since we are fixing the component already, I've added a quick solution for handling invalid namespace/slug values.

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzo-cavazzi lorenzo-cavazzi merged commit 2945fb9 into main Sep 24, 2024
18 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/fix-session-page branch September 24, 2024 11:13
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants