Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support for data connectors on user and group namespaces #3315

Merged
merged 9 commits into from
Sep 30, 2024
Merged

feat!: support for data connectors on user and group namespaces #3315

merged 9 commits into from
Sep 30, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Sep 12, 2024 •
edited
Loading

  • show/edit data connectors on the group page
  • show/edit data connectors to the user page

/deploy renku-data-services=leafty/feat-namespaced-data-connectors-4

@ciyer ciyer force-pushed the ciyer/storage-to-data-connectors branch 2 times, most recently from 1db9034 to e8e6097 Compare September 17, 2024 10:07
Base automatically changed from ciyer/storageV2-refactor to build/data-connectors September 18, 2024 07:13
@ciyer ciyer changed the title wip: initial support for data connectors [wip] initial support for data connectors Sep 18, 2024
@ciyer ciyer force-pushed the ciyer/storage-to-data-connectors branch 4 times, most recently from 64d9556 to 52d9aa3 Compare September 19, 2024 07:32
@ciyer ciyer force-pushed the ciyer/storage-to-data-connectors branch 3 times, most recently from 4f80050 to da51bb4 Compare September 20, 2024 14:01
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3315.dev.renku.ch

@ciyer ciyer force-pushed the ciyer/storage-to-data-connectors branch from 388e991 to d3efa1b Compare September 24, 2024 09:28
@ciyer ciyer marked this pull request as ready for review September 24, 2024 09:28
@ciyer ciyer requested a review from a team as a code owner September 24, 2024 09:28
leafty
leafty reviewed Sep 24, 2024
View reviewed changes
client/src/features/projectsV2/api/projectV2.enhanced-api.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not inject into the projectV2 API. In fact, the PR which updates the API files does split each API cleanly so that each one is handled separately. See: #3299.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6572869

leafty
leafty requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some first comments here.

client/src/features/ProjectPageV2/ProjectPageContent/DataSources/DataSourceModal.tsx Outdated Show resolved Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx Show resolved Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorModal/DataConnectorModalBody.tsx Show resolved Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorModal/index.tsx Show resolved Hide resolved
client/src/features/dataConnectorsV2/components/dataConnector.utils.ts Show resolved Hide resolved
client/src/features/usersV2/show/UserShow.tsx
<section className="mt-3">
<Row>
<Col className="order-3" xs={12} xl={8}>
<DataConnectorsBox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, it is very difficult for users to access this page (there is no top-level navigation link for it). Which means it is very difficult to create personal data connectors if we do not have a top-level create menu.

client/src/features/usersV2/show/UserShow.tsx Outdated Show resolved Hide resolved
@ciyer @leafty
Update client/src/features/usersV2/show/UserShow.tsx
351d1d7 
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
leafty
leafty reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should be good to go with issues fixed.

tests/cypress/e2e/groupV2.spec.ts Outdated Show resolved Hide resolved
@ciyer ciyer changed the title [wip] initial support for data connectors feat: initial support for data connectors Sep 27, 2024
@ciyer ciyer changed the title feat: initial support for data connectors feat: support for data connectors on user and group namespaces Sep 27, 2024
@ciyer ciyer changed the title feat: support for data connectors on user and group namespaces feat!: support for data connectors on user and group namespaces Sep 27, 2024
@leafty leafty self-requested a review September 30, 2024 07:33
@ciyer ciyer merged commit f325fdd into build/data-connectors Sep 30, 2024
40 of 45 checks passed
@ciyer ciyer deleted the ciyer/storage-to-data-connectors branch September 30, 2024 08:15
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

ciyer added a commit that referenced this pull request Sep 30, 2024
@ciyer
feat!: support for data connectors on user and group namespaces (#3315)
8019ace
ciyer added a commit that referenced this pull request Oct 4, 2024
@ciyer
feat!: support for data connectors on user and group namespaces (#3315)
29664d5
ciyer added a commit that referenced this pull request Oct 9, 2024
@ciyer
feat!: support for data connectors on user and group namespaces (#3315)
53504a6
ciyer added a commit that referenced this pull request Oct 14, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346)
e3d41c7 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0

build: update to latest project api spec
ciyer added a commit that referenced this pull request Oct 16, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346) (#3359)
47d82b1 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
ciyer added a commit that referenced this pull request Oct 17, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346) (#3359)
9bb0f67 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciyer @RenkuBot @leafty