Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: styles for edit launcher environment list #3360

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: styles for edit launcher environment list #3360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8adc71
fix: Improve styles for edit launcher environment list
andre-code Oct 14, 2024
3a3ed79
Merge branch 'main' into andrea/fix-existing-env-styles-2.0
andre-code Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions client/src/features/sessionsV2/SessionLauncherFormContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import cx from "classnames";
import { useEffect, useMemo, useState } from "react";
import { SingleValue } from "react-select";
import { Globe2 } from "react-bootstrap-icons";
import {
Control,
Controller,
Expand All @@ -29,18 +29,18 @@ import {
UseFormSetValue,
UseFormWatch,
} from "react-hook-form";
import { Input, Label, ListGroup, ListGroupItem, Row } from "reactstrap";
import { Globe2 } from "react-bootstrap-icons";
import { SingleValue } from "react-select";
import { Input, Label, ListGroup, ListGroupItem } from "reactstrap";

import { ErrorAlert, WarnAlert } from "../../components/Alert";
import { Loader } from "../../components/Loader";
import { TimeCaption } from "../../components/TimeCaption";
import { RtkErrorAlert } from "../../components/errors/RtkErrorAlert";
import { useGetSessionEnvironmentsQuery } from "./sessionsV2.api";
import { EnvironmentKind, SessionEnvironment } from "./sessionsV2.types";
import { ErrorAlert, WarnAlert } from "../../components/Alert.jsx";
import { useGetResourcePoolsQuery } from "../dataServices/computeResources.api";
import { ResourceClass } from "../dataServices/dataServices.types";
import { SessionClassSelectorV2 } from "../session/components/options/SessionClassOption";
import { useGetSessionEnvironmentsQuery } from "./sessionsV2.api";
import { EnvironmentKind, SessionEnvironment } from "./sessionsV2.types";

export interface SessionLauncherForm {
name: string;
Expand Down Expand Up @@ -165,6 +165,7 @@ export default function SessionLauncherFormContent({

<div
className={cx(
"mb-3",
watchEnvironmentKind !== "global_environment" && "d-none"
)}
>
Expand All @@ -187,7 +188,7 @@ export default function SessionLauncherFormContent({
name="environment_id"
render={({ field }) => (
<>
<Row>
<ListGroup>
{environments.map((environment) => (
<SessionEnvironmentItem
key={environment.id}
Expand All @@ -198,7 +199,7 @@ export default function SessionLauncherFormContent({
control={control}
/>
))}
</Row>
</ListGroup>
<Input
className={cx(errors.environment_id && "is-invalid")}
id="addSessionLauncherEnvironmentId"
Expand Down
Loading