refactor: move data connector form state to slice #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
ciyer/data-connecotrs-refactor
branch
9 times, most recently
from
897be72
to
c01376c
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3386.dev.renku.ch |
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/data-connecotrs-refactor
branch
from
64d6745
to
2b5159e
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
refactor: move validationSucceeded state to a slice refactor: move action status state to the slice refactor: move cloud storage state to the slice refactor: move flat data connector state to the slice refactor: move the setStateSafe logic to the slice refactor: move up code to set flat data connector refactor: move actions out of the top level of modal refactor: move data connector validation minor: reset form state after a data connector has been linked to a project
ciyer
force-pushed
the
ciyer/data-connecotrs-refactor
branch
from
2b5159e
to
ab1f537
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
ciyer
changed the title
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
leafty
reviewed
Nov 5, 2024
client/src/features/dataConnectorsV2/components/DataConnectorModal/DataConnectorModalFooter.tsx
Outdated
Show resolved
Hide resolved
leafty
reviewed
Nov 5, 2024
client/src/features/dataConnectorsV2/components/DataConnectorModal/index.tsx
Show resolved
Hide resolved
leafty
reviewed
Nov 5, 2024
ciyer
had a problem deploying
to
renku-ci-ui-3386
GitHub Actions
Failure
ciyer
temporarily deployed
to
renku-ci-ui-3386
GitHub Actions
Inactive
leafty
approved these changes
Nov 6, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy