UI for configuring KG integration #374

ciyer · 2019-01-30T10:41:14Z

lorenzo-cavazzi · 2019-02-27T15:41:33Z

Third point of #369 is not addressed by this PR, please let me know if I should open a new issue for that

lorenzo-cavazzi · 2019-02-27T16:10:57Z

When the project is private the webhook check fails and a error alert is displayed. Should I check for the visibility level or is this temporary?
I remember some discussions around this topic during the last meeting but I am not sure which decision was taken.

ableuler · 2019-02-28T07:56:30Z

Third point of #369 is not addressed by this PR, please let me know if I should open a new issue for that

yes, please do so.

lorenzo-cavazzi · 2019-02-28T09:58:34Z

As discussed, add a disclaimer for the webhook creation in the new project page when creating a private project.

ableuler

Good work. I'd suggest to let this PR sit until the support for private projects on the graph side is finished.

src/api-client/index.js

src/project/Project.present.js

rokroskar · 2019-03-04T23:44:47Z

I'd suggest to let this PR sit until the support for private projects on the graph side is finished.

That looks to be done in SwissDataScienceCenter/renku-graph#50

lorenzo-cavazzi · 2019-03-20T15:38:36Z

Waiting for SwissDataScienceCenter/renku-gateway#107 to be closed

lorenzo-cavazzi · 2019-03-25T14:48:11Z

A preview is now available at https://lorenzotest.dev.renku.ch

lorenzo-cavazzi · 2019-03-25T17:03:28Z

I fear the warning popups are not closed correctly right now: they re-appear sometimes when navigating through the project tabs. It doesn't take long to fix this, but first please confirm me if this visualization is fine or if you prefer something different

lorenzo-cavazzi · 2019-03-26T16:46:48Z

I can't re-request the review either, this message should do it :)

rokroskar · 2019-03-27T10:53:33Z

@ableuler can you review since @ciyer and @lorenzo-cavazzi seem to be in some sort of review twilight zone?

src/project/Project.present.js

ciyer · 2019-03-28T10:05:08Z

src/project/new/ProjectNew.present.js

+    let warningPrivate = null;
+    if (this.props.value === "private") {
+      warningPrivate = <FormText color="danger">
+        Please be aware that some metadata may become public even for private projects


New text: "The Knowledge Graph may make some metadata public; the contents will remain private."

lorenzo-cavazzi · 2019-03-28T10:42:35Z

Waiting for internal project webhook creation support: SwissDataScienceCenter/renku-graph#62

rokroskar · 2019-03-28T12:32:00Z

renku-graph ;)

lorenzo-cavazzi · 2019-03-29T07:37:40Z

wops... of course :)

Webhook creation for new projects and alert display for older projects. Alerts added to shared components.

ciyer force-pushed the 369-kg-integration branch from 999cb45 to a2af5c4 Compare February 13, 2019 13:34

lorenzo-cavazzi force-pushed the 369-kg-integration branch from a2af5c4 to c6b254b Compare February 27, 2019 15:34

lorenzo-cavazzi changed the title ~~WIP: UI for configuring KG integration~~ UI for configuring KG integration Feb 27, 2019

lorenzo-cavazzi requested a review from ableuler February 27, 2019 15:43

rokroskar mentioned this pull request Feb 27, 2019

Connect graph services SwissDataScienceCenter/renku-gateway#91

Merged

ableuler previously requested changes Feb 28, 2019

View reviewed changes

src/api-client/index.js Show resolved Hide resolved

src/project/Project.present.js Outdated Show resolved Hide resolved

src/project/Project.present.js Outdated Show resolved Hide resolved

lorenzo-cavazzi force-pushed the 369-kg-integration branch 2 times, most recently from ce51c96 to a2021a1 Compare March 7, 2019 16:20

lorenzo-cavazzi requested a review from ableuler March 7, 2019 16:21

lorenzo-cavazzi force-pushed the 369-kg-integration branch from a2021a1 to 18797f6 Compare March 8, 2019 13:02

ciyer changed the title ~~UI for configuring KG integration~~ WIP: UI for configuring KG integration Mar 18, 2019

lorenzo-cavazzi mentioned this pull request Mar 20, 2019

Use graph services for lineage display #392

Merged

lorenzo-cavazzi force-pushed the 369-kg-integration branch from 18797f6 to a6cc641 Compare March 25, 2019 08:20

lorenzo-cavazzi changed the title ~~WIP: UI for configuring KG integration~~ UI for configuring KG integration Mar 25, 2019

lorenzo-cavazzi force-pushed the 369-kg-integration branch from a6cc641 to 1948d69 Compare March 26, 2019 10:59

lorenzo-cavazzi force-pushed the 369-kg-integration branch 2 times, most recently from 052bc8a to f0e5fae Compare March 28, 2019 09:30

ciyer commented Mar 28, 2019

View reviewed changes

lorenzo-cavazzi force-pushed the 369-kg-integration branch from f0e5fae to 695dc4f Compare March 28, 2019 10:35

lorenzo-cavazzi changed the title ~~UI for configuring KG integration~~ [WIP] UI for configuring KG integration Mar 28, 2019

lorenzo-cavazzi force-pushed the 369-kg-integration branch from 695dc4f to 5f32775 Compare March 29, 2019 16:41

lorenzo-cavazzi changed the title ~~[WIP] UI for configuring KG integration~~ UI for configuring KG integration Mar 29, 2019

lorenzo-cavazzi force-pushed the 369-kg-integration branch from 5f32775 to d866d72 Compare April 2, 2019 13:06

lorenzo-cavazzi self-requested a review April 2, 2019 13:14

lorenzo-cavazzi previously approved these changes Apr 2, 2019

View reviewed changes

Graph Webhook support

fa0c91d

Webhook creation for new projects and alert display for older projects. Alerts added to shared components.

lorenzo-cavazzi dismissed their stale review via fa0c91d April 2, 2019 13:19

lorenzo-cavazzi force-pushed the 369-kg-integration branch from d866d72 to fa0c91d Compare April 2, 2019 13:19

lorenzo-cavazzi self-requested a review April 2, 2019 13:20

lorenzo-cavazzi approved these changes Apr 2, 2019

View reviewed changes

lorenzo-cavazzi merged commit 9c56513 into master Apr 2, 2019

lorenzo-cavazzi deleted the 369-kg-integration branch April 2, 2019 13:27

ableuler mentioned this pull request Apr 4, 2019

Refactor lineage view to use graph service #362

Closed

1 task

lorenzo-cavazzi added this to the 0.5.0 milestone May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI for configuring KG integration #374

UI for configuring KG integration #374

ciyer commented Jan 30, 2019

lorenzo-cavazzi commented Feb 27, 2019

lorenzo-cavazzi commented Feb 27, 2019

ableuler commented Feb 28, 2019

lorenzo-cavazzi commented Feb 28, 2019

ableuler left a comment

rokroskar commented Mar 4, 2019

lorenzo-cavazzi commented Mar 20, 2019 •

edited

Loading

lorenzo-cavazzi commented Mar 25, 2019

lorenzo-cavazzi commented Mar 25, 2019

lorenzo-cavazzi commented Mar 26, 2019

rokroskar commented Mar 27, 2019

ciyer Mar 28, 2019

lorenzo-cavazzi commented Mar 28, 2019 •

edited

Loading

rokroskar commented Mar 28, 2019

lorenzo-cavazzi commented Mar 29, 2019

UI for configuring KG integration #374

UI for configuring KG integration #374

Conversation

ciyer commented Jan 30, 2019

lorenzo-cavazzi commented Feb 27, 2019

lorenzo-cavazzi commented Feb 27, 2019

ableuler commented Feb 28, 2019

lorenzo-cavazzi commented Feb 28, 2019

ableuler left a comment

Choose a reason for hiding this comment

rokroskar commented Mar 4, 2019

lorenzo-cavazzi commented Mar 20, 2019 • edited Loading

lorenzo-cavazzi commented Mar 25, 2019

lorenzo-cavazzi commented Mar 25, 2019

lorenzo-cavazzi commented Mar 26, 2019

rokroskar commented Mar 27, 2019

ciyer Mar 28, 2019

Choose a reason for hiding this comment

lorenzo-cavazzi commented Mar 28, 2019 • edited Loading

rokroskar commented Mar 28, 2019

lorenzo-cavazzi commented Mar 29, 2019

lorenzo-cavazzi commented Mar 20, 2019 •

edited

Loading

lorenzo-cavazzi commented Mar 28, 2019 •

edited

Loading