Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge graph warning for new projects fixed #419

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Apr 3, 2019

closes #417

The warning now appears also for internal projects and it should be more clear that it's not an error.
A link to the lineage page in the docs is provided.

This is the "new project" page

Screenshot from 2019-04-03 13-10-36

Temporarily test link: https://lorenzotest.dev.renku.ch/
It's a bit fancy compared to the previous solution, let me know if you like it or not.

The warning now appears also for internal projects and it should be more
clear that it's not an error.
A link to the lineage page in the docs is provided.
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@vfried vfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ciyer it looks really good!

@lorenzo-cavazzi lorenzo-cavazzi merged commit d09370a into master Apr 3, 2019
@lorenzo-cavazzi lorenzo-cavazzi deleted the 417-lineage-info-new-project branch April 11, 2019 09:42
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.5.0 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New project page metadata info
3 participants