Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File display #420

Merged
merged 1 commit into from
Apr 16, 2019
Merged

File display #420

merged 1 commit into from
Apr 16, 2019

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Apr 8, 2019 •
edited
Loading

This is to address the issue #400, at the moment it looks like this...

image

Some things will need to be addressed after this PR is merged:

  • See if we can fetch LFS Files or if we can know if a file is from GIT LFS
  • Being able to change between branches (now it shows master only)
  • Add new formats of files to preview
  • Better integration with launching JupyterLab

ciyer
ciyer previously requested changes Apr 8, 2019
View reviewed changes
src/api-client/project.js Outdated Show resolved Hide resolved
src/api-client/project.js Outdated Show resolved Hide resolved
src/api-client/project.js Outdated Show resolved Hide resolved
src/api-client/project.js Outdated Show resolved Hide resolved
src/api-client/project.js Outdated Show resolved Hide resolved
src/api-client/project.js Outdated Show resolved Hide resolved
src/file/Lineage.present.js Outdated Show resolved Hide resolved
src/utils/treeview/data.js Outdated Show resolved Hide resolved
src/utils/treeview/data.js Outdated Show resolved Hide resolved
@vfried vfried force-pushed the 400-improve-file-display branch 3 times, most recently from 27a8c0e to 82e937b Compare April 8, 2019 14:06
@ciyer ciyer dismissed their stale review April 11, 2019 07:07

All requests resolved.

@vfried vfried force-pushed the 400-improve-file-display branch 3 times, most recently from 886ef4a to a4a3a90 Compare April 12, 2019 13:48
@vfried vfried requested a review from ciyer April 12, 2019 13:50
@vfried vfried changed the title WIP File display File display Apr 12, 2019
ciyer
ciyer requested changes Apr 14, 2019
View reviewed changes
src/file/File.container.js Outdated Show resolved Hide resolved
@vfried vfried merged commit a8c73bb into master Apr 16, 2019
This was referenced Apr 24, 2019
Closed
Closed
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.5.0 milestone May 21, 2019
This was referenced May 29, 2019
Closed
Closed
@ciyer ciyer deleted the 400-improve-file-display branch June 6, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

@lorenzo-cavazzi lorenzo-cavazzi Awaiting requested review from lorenzo-cavazzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vfried @ciyer @lorenzo-cavazzi