fix(notebook): avoid to create notebook url for anonymous users #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-cavazzi
force-pushed
the
000-fix-notebook-url
branch
from
70405b3
to
48b24da
Compare
lorenzo-cavazzi
force-pushed
the
000-fix-notebook-url
branch
from
48b24da
to
61f2e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project's notebook URL computation generates an API call (before #460, it was computed locally) that results in a
401response for anonymous users, which triggers the authentication. There is no need to compute that URL for users who can't possibly have a running notebook server.To reproduce: open any public project on dev as anonymous user (e.g. https://dev.renku.ch/projects/72). This will trigger authentication due to a call to
https://dev.renku.ch/api/notebooks/.../f6404d191d8067eda7a7083efdf57e4b7f56922b