-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pipeline starts without creating a trigger #512
Conversation
fd45b35
to
a0151bb
Compare
how old is old? |
I'm not sure, I left the office and couldn't finish investigating on the issue. I was planning on trying to check tomorrow what's going on. |
a0151bb
to
c253953
Compare
I realised some forks where failing because I was trying to start the pipeline before the project was fully forked. For this reason I now check project import status as stated here: https://docs.gitlab.com/ee/api/project_import_export.html#import-status I set up a timer and try 10 times to see if the pipeline is ready to be run or not (So far it was always successful on the 1st time). I think the older projects where taking longer to being fetched or something and this is why they where failing. |
c253953
to
8a2faca
Compare
2174b66
to
a12a12e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything works fine, great!
A note on the modal
I minor suggestion would be to add stronger feedback to the user while the fork is ongoing. An example would be
- disable the 2 buttons while forking
- add a short sentence like
forking project...
before the spinning wheel.
Since it's a minor detail, feel free to ignore this suggestion and merge if you think it's not particularly useful 🙂
I tried it out; the feature is very nice and the code looks good! I agree, though, that the feedback on the modal dialog should be more explicit: as you suggest, the fork and cancel buttons should be disabled and a short description of what's going on should be there. |
a12a12e
to
84c5e1d
Compare
84c5e1d
to
0d8d36d
Compare
Done... now buttons are disabled and there is a message as in the following image when the project is being forked. (The image doesn't show the disabled buttons but they are disabled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Very useful feature
The pipeline starts now without creating a trigger.
To test fork a project and go to CI/CD => pipelines in gitlab and you will see that after forking a project there is a pipeline running.
For some reason it fails for old projects. I think in the future we can after redirect offer the option to restart failed pipelines (Like for Knowledge Graph).
Closes #511