Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pipeline starts without creating a trigger #512

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Jul 8, 2019

The pipeline starts now without creating a trigger.

To test fork a project and go to CI/CD => pipelines in gitlab and you will see that after forking a project there is a pipeline running.

For some reason it fails for old projects. I think in the future we can after redirect offer the option to restart failed pipelines (Like for Knowledge Graph).

Closes #511

@vfried vfried requested a review from a team as a code owner July 8, 2019 15:11
@vfried vfried force-pushed the 511-improve-ci-pipeline-start branch from fd45b35 to a0151bb Compare July 8, 2019 15:16
@rokroskar
Copy link
Member

For some reason it fails for old projects.

how old is old?

@vfried vfried changed the title feat: pipeline starts without creating a trigger WIP feat: pipeline starts without creating a trigger Jul 8, 2019
@vfried
Copy link
Contributor Author

vfried commented Jul 8, 2019

For some reason it fails for old projects.

how old is old?

I'm not sure, I left the office and couldn't finish investigating on the issue. I was planning on trying to check tomorrow what's going on.

@vfried vfried force-pushed the 511-improve-ci-pipeline-start branch from a0151bb to c253953 Compare July 9, 2019 12:50
@vfried vfried changed the title WIP feat: pipeline starts without creating a trigger feat: pipeline starts without creating a trigger Jul 9, 2019
@vfried
Copy link
Contributor Author

vfried commented Jul 9, 2019

For some reason it fails for old projects.

how old is old?

I'm not sure, I left the office and couldn't finish investigating on the issue. I was planning on trying to check tomorrow what's going on.

I realised some forks where failing because I was trying to start the pipeline before the project was fully forked. For this reason I now check project import status as stated here: https://docs.gitlab.com/ee/api/project_import_export.html#import-status

I set up a timer and try 10 times to see if the pipeline is ready to be run or not (So far it was always successful on the 1st time).

I think the older projects where taking longer to being fetched or something and this is why they where failing.

@vfried vfried force-pushed the 511-improve-ci-pipeline-start branch from c253953 to 8a2faca Compare July 9, 2019 12:59
@vfried vfried force-pushed the 511-improve-ci-pipeline-start branch 3 times, most recently from 2174b66 to a12a12e Compare July 12, 2019 14:42
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--

@lorenzo-cavazzi lorenzo-cavazzi self-requested a review July 12, 2019 14:52
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything works fine, great!


A note on the modal

Screenshot from 2019-07-12 16-31-08

I minor suggestion would be to add stronger feedback to the user while the fork is ongoing. An example would be

  • disable the 2 buttons while forking
  • add a short sentence like forking project... before the spinning wheel.

Since it's a minor detail, feel free to ignore this suggestion and merge if you think it's not particularly useful 🙂

@ciyer
Copy link
Contributor

ciyer commented Jul 12, 2019

I tried it out; the feature is very nice and the code looks good! I agree, though, that the feedback on the modal dialog should be more explicit: as you suggest, the fork and cancel buttons should be disabled and a short description of what's going on should be there.

@vfried vfried force-pushed the 511-improve-ci-pipeline-start branch from 84c5e1d to 0d8d36d Compare July 14, 2019 16:49
@vfried
Copy link
Contributor Author

vfried commented Jul 14, 2019

I tried it out; the feature is very nice and the code looks good! I agree, though, that the feedback on the modal dialog should be more explicit: as you suggest, the fork and cancel buttons should be disabled and a short description of what's going on should be there.

Done... now buttons are disabled and there is a message as in the following image when the project is being forked. (The image doesn't show the disabled buttons but they are disabled)

image

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Very useful feature

@vfried vfried merged commit af8064b into master Jul 15, 2019
@ciyer ciyer added this to the 0.6.0 milestone Jul 19, 2019
@ciyer ciyer deleted the 511-improve-ci-pipeline-start branch August 20, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start pipeline without creating trigger (after project fork)
4 participants