Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebook): improve user feedback when stopping a notebook #520

Closed
wants to merge 1 commit into from

Conversation

lorenzo-cavazzi
Copy link
Member

This PR changes the user experience when stopping a notebook server.

After the user clicks on "Stop server", a modal will appear informing that the server is stopping. It disappears only when the response comes from the "delete server" API -- usually a few seconds.
The server status will be displayed correctly once the modal is gone.

Screenshot from 2019-07-15 15-27-45

fix #513 -- but wait to merge this until a decision on how to address the original issue is taken.

<Modal isOpen={this.props.show}>
<ModalHeader>Stopping server</ModalHeader>
<ModalBody>
<p>The following notebook server is going to stop soon</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording: The following notebook server is shutting down:

@ciyer
Copy link
Contributor

ciyer commented Jul 18, 2019

I also found a weird case: If I start two notebook servers and shut one down, I sometimes get this error, and the UI goes blank:

[Error] TypeError: undefined is not an object (evaluating 'e[r+n]') — notebook-servers.js:37
	po (2.140d6c32.chunk.js:1:1195845)
	callback (2.140d6c32.chunk.js:1:1200922)
	ro (2.140d6c32.chunk.js:1:1193676)
	no (2.140d6c32.chunk.js:1:1193475)
	Uo (2.140d6c32.chunk.js:1:1203648)
	Go (2.140d6c32.chunk.js:1:1205966)
	(anonymous function) (2.140d6c32.chunk.js:1:1219195)
	unstable_runWithPriority (2.140d6c32.chunk.js:1:1229940)
	Os (2.140d6c32.chunk.js:1:1219152)
	Ns (2.140d6c32.chunk.js:1:1218906)
	Ms (2.140d6c32.chunk.js:1:1218251)
	ws (2.140d6c32.chunk.js:1:1217272)
	Qo (2.140d6c32.chunk.js:1:1216146)
	enqueueSetState (2.140d6c32.chunk.js:1:1165401)
	setState (2.140d6c32.chunk.js:1:1115717)
	onStateChange (2.140d6c32.chunk.js:1:404024)
	(anonymous function)
	d (2.140d6c32.chunk.js:1:444680)
	value (main.85bbd084.chunk.js:1:3277)
	value (main.85bbd084.chunk.js:1:5034)
	value (main.85bbd084.chunk.js:1:4951)
	(anonymous function) (main.85bbd084.chunk.js:1:42387)
	promiseReactionJob

@lorenzo-cavazzi
Copy link
Member Author

closed in favor of this #530

@lorenzo-cavazzi lorenzo-cavazzi modified the milestone: 0.6.0 Jul 22, 2019
@lorenzo-cavazzi lorenzo-cavazzi deleted the 513-stop-notebook branch July 22, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the notebook status when stopping a server
2 participants