Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lineage): user can zoom in and out of the graph #539

Merged
merged 1 commit into from
Jul 23, 2019
Merged

feat(lineage): user can zoom in and out of the graph #539

merged 1 commit into from
Jul 23, 2019

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Jul 23, 2019 •
edited
Loading

The user can use the mouse to zoom in and out of the graph and drag the graph in the viewport.

Closes #534

@vfried vfried requested a review from a team as a code owner July 23, 2019 08:21
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.6.1 milestone Jul 23, 2019
@vfried vfried force-pushed the 534-graph-zoom branch 2 times, most recently from 5ff32b8 to d1b7937 Compare July 23, 2019 12:55
lorenzo-cavazzi
lorenzo-cavazzi requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me!

I have added a minor detail in the zoom button styling, feel free to change/improve it if you don't like the appearance.

src/file/Lineage.present.js Outdated Show resolved Hide resolved
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature was really needed!

@vfried vfried merged commit d054522 into master Jul 23, 2019
@ciyer ciyer deleted the 534-graph-zoom branch August 20, 2019 07:10
@snyk-bot snyk-bot mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Implement graph zoom
2 participants
@vfried @lorenzo-cavazzi