Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit project metadata bug #554

Merged
merged 4 commits into from
Aug 14, 2019
Merged

fix: edit project metadata bug #554

merged 4 commits into from
Aug 14, 2019

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jul 30, 2019

Fix bug that prevents editing of project metadata.

Fix #427.

@ciyer ciyer changed the title WIP: Edit project metadata bug fix fix: edit project metadata bug Aug 4, 2019
@ciyer ciyer marked this pull request as ready for review August 4, 2019 19:44
@ciyer ciyer requested a review from a team as a code owner August 4, 2019 19:44
@ciyer
Copy link
Contributor Author

ciyer commented Aug 4, 2019

Can test on https://sekhar.dev.renku.ch. May need to reload the page, as the old logic may be cached.

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Aug 5, 2019

It works for me.
There is a minor issue: project tags are not updated in the projects list -- this is true only for "starred" and "your projects", but it is related to #408 and the logic behind those 2 tabs need to be updated.

P.S. It may be a good idea to add a margin under the Update button. I added this in another commit, feel free to throw it away if you don't like it.

Screenshot from 2019-08-05 13-45-43

lorenzo-cavazzi
lorenzo-cavazzi previously approved these changes Aug 5, 2019
@ciyer
Copy link
Contributor Author

ciyer commented Aug 14, 2019

Thanks for fixing the spacing. Looks better now.

@ciyer ciyer merged commit 3da7e9f into master Aug 14, 2019
@ciyer ciyer deleted the 427-edit-project-md branch August 14, 2019 12:05
@ciyer ciyer added this to the 0.6.3 milestone Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings->Edit tags and description does not work
3 participants