Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notebooks): correctly update pipeline information #592

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Sep 3, 2019

This addresses an annoying bug happening in the following situation

  • the user tries to start an interactive environment from a commit where all the pipelines/jobs related to building the Docker image are available.
  • later, the user selects another commit where the pipeline or the job is not found

In this case (as well as a couple of similar combinations), the information about the Docker images availability wasn't updated correctly.

Testing: the easiest way to reproduce the issue is to fork a project, then try to select an older commit -- the pipeline to build the Docker image exists only on the latest commit on the master branch

fix #590

@rokroskar
Copy link
Member

doesn't this close #590?

@lorenzo-cavazzi
Copy link
Member Author

doesn't this close #590?

it does, there is a "re #590" in the description but I guess re is not a valid keyword in Github. Let me change it to fix

@lorenzo-cavazzi lorenzo-cavazzi merged commit 367b5bf into master Sep 6, 2019
@ciyer ciyer added this to the sprint-2019-08-16 milestone Sep 6, 2019
@lorenzo-cavazzi lorenzo-cavazzi deleted the 590-no-pipeline branch September 25, 2019 16:14
@ciyer ciyer modified the milestones: sprint-2019-08-16, 0.7.0 Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading image availability information during notebook launch
3 participants