Display commit and timestamp information about the file in the file view

[ciyer]

Commit hash, with link to commit in github, commit message, commit author, and commit date/time has been added to the display.

It looks like

Running on https://sekhartest.dev.renku.ch/ for testing.

Fix #487.

[ciyer]

@cchoirat If you get a chance to try this out, we would be interested in your feedback.

[cchoirat]

is it on dev?

[ciyer]

Not yet, but you can test on https://sekhartest.dev.renku.ch/

[vfried]

I like it but i think for smaller screens it might be taking too much space... I think we could do something like this...

For this i made a small change:
I made the font small, replaced the div for a span and set the span into the right (float-right)... i didn't checked larger commit messages but i think we could just cut the string.

[vfried]

I left a message with suggested changes, if you don't think they are right you can dismiss them.

[lorenzo-cavazzi]

@vfried I think floating right doesn't help in a small screen unless the commit message is very short.

I kind of prefer the 2 lines version. I would probably cut the commit message chars at a given number (60? 100?) to avoid long commit messages taking multiple lines.

[vfried]

What I meant with that is that it that will give a bit more of room for code, since it would only be one line instead of 2... the throw right doesn't solve the long commit messages problem, and that's why i mention above that we need to crop it.

[lorenzo-cavazzi]

Ops I see only now that you mentioned cutting down long commit messages, guess the comment was edited but I didn't refresh the page 😅

[ciyer]

I'm using the "title" that comes with the commit information from gitlab. This is restricted to some number of characters (but I need to look at the code to see how many).

[lorenzo-cavazzi]

Look good, I found only a small issue related to the graphButton that is not rendered anymore (the rightmost in the following screen taken on dev)

[lorenzo-cavazzi]

Lgtm now 👍
I tried a long commit message and it seems to go into the UI untouched. I would address this in the current PR, but feel free to merge it if you think the current behavior is acceptable.

https://sekhartest.dev.renku.ch/projects/lorenzo.cavazzi.tech/zurich-bikes-tutorial/files/blob/aaa.txt

[ciyer]

I see. The title field took that commit message up to the first \n. I've limited it to 120 chars now.

[lorenzo-cavazzi]

Works as advertized 🎉

[ciyer]

With some flexbox magic fairy dust, I have it working as Virginia suggested, if there is space:

And otherwise, as before:

[lorenzo-cavazzi]

lgtm

[vfried]

Well done, looks good!