Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasets): with link to external source and author affiliation #688

Merged
merged 1 commit into from
Nov 22, 2019
Merged

feat(datasets): with link to external source and author affiliation #688

merged 1 commit into from
Nov 22, 2019

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Nov 22, 2019 •
edited
Loading

Added link to external source and author affiliation.

image
Test Env: https://virginiatest.dev.renku.ch/

Closes #687

@vfried vfried requested a review from a team as a code owner November 22, 2019 12:08
@vfried vfried force-pushed the 687-dataset-metadata-changes branch from b4f7f70 to 0c39d84 Compare November 22, 2019 12:08
@vfried vfried self-assigned this Nov 22, 2019
@rokroskar
Copy link
Member

This is looking really nice! I would maybe add the link provided by the sameAs field, if it exists, and display it with the details of the dataset since that is a critical piece of identifying information.

@vfried
Copy link
Contributor Author

vfried commented Nov 22, 2019

This is looking really nice! I would maybe add the link provided by the sameAs field, if it exists, and display it with the details of the dataset since that is a critical piece of identifying information.

Like this.. ?
image

@vfried vfried force-pushed the 687-dataset-metadata-changes branch from 0c39d84 to 34190c1 Compare November 22, 2019 13:47
@rokroskar
Copy link
Member

I wonder if it would make sense to have both, e.g.

source: https://zenodo.org/...
DOI: https://doi.org/...

If the doi doesn't exist we just show the source.

@vfried vfried force-pushed the 687-dataset-metadata-changes branch from 34190c1 to 6ad42c0 Compare November 22, 2019 13:58
@vfried
Copy link
Contributor Author

vfried commented Nov 22, 2019 •
edited
Loading

Done...

image

@rokroskar
Copy link
Member

That makes sense to me! and if DOI is not there that line is missing?

@vfried
Copy link
Contributor Author

vfried commented Nov 22, 2019

That makes sense to me! and if DOI is not there that line is missing?

Yes

@vfried vfried force-pushed the 687-dataset-metadata-changes branch from 6ad42c0 to b602b28 Compare November 22, 2019 14:17
rokroskar
rokroskar approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ciyer
ciyer approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as a feature. With this, it is very easy to get to the original source of the data.

@vfried vfried merged commit 181ef89 into master Nov 22, 2019
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.7.2 milestone Nov 22, 2019
@ciyer ciyer deleted the 687-dataset-metadata-changes branch March 25, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar approved these changes

@ciyer ciyer ciyer approved these changes

Assignees

@vfried vfried

Labels
None yet
Projects
None yet
Milestone
0.7.2
Development

Successfully merging this pull request may close these issues.

Adapt dataset ui to new changes
4 participants
@vfried @rokroskar @ciyer @lorenzo-cavazzi