Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close pop-up after successful fork operation #745

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 31, 2020

Fix #723

Solution available for testing on https://sekhar.dev.renku.ch

To test -- fork a project and see that

  1. The fork popup dialog disappears when the fork succeeds
    1.1 The dialog remains until the browser has loaded the new forked project
  2. The dialog stays around when the fork fails and notifies the user of the problem.

Check on at least two browsers, as the behavior was different before on Chrome vs. Safari or Firefox.

@ciyer ciyer requested a review from a team as a code owner January 31, 2020 17:06
@ciyer ciyer changed the title Close pop-up after successful fork operation WIP: Close pop-up after successful fork operation Jan 31, 2020
@ciyer ciyer changed the title WIP: Close pop-up after successful fork operation Close pop-up after successful fork operation Feb 3, 2020
vfried
vfried previously approved these changes Feb 4, 2020
Copy link
Contributor

@vfried vfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, and good improvements to the code on top of the fix!

@ciyer ciyer merged commit 46236ac into master Feb 5, 2020
@ciyer ciyer deleted the 723-fork-popup branch February 5, 2020 09:44
@lorenzo-cavazzi lorenzo-cavazzi added this to the sprint-2020-01-20 milestone Feb 12, 2020
@ciyer ciyer modified the milestones: sprint-2020-01-20, 0.8.0 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork popup stays after forking
4 participants