Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(environments): add requested resources info #834

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Mar 13, 2020

In the environments pages, a new column shows the resources allocated for every environment

A preview is available here: https://lorenzotest.dev.renku.ch/

How to test
Start an environment in any project. After it is up and running, the environments table should show the requested resources in the new Resources column

Screenshot_20200313_161603

This requires SwissDataScienceCenter/renku-notebooks#261
fix #788

In the environments pages, a new column shows the resources allocated
for every environment

fix #788
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner March 13, 2020 15:18
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very helpful to see what resources an environment has. I made a minor change to the formatting that I like a little more. If you agree, go ahead and squash and merge. If you don't like it, then discard my commit and I will re-approve.

@lorenzo-cavazzi lorenzo-cavazzi merged commit b26a939 into master Mar 17, 2020
@lorenzo-cavazzi lorenzo-cavazzi deleted the 788-requested-resources branch March 17, 2020 14:01
@lorenzo-cavazzi lorenzo-cavazzi added this to the sprint-2020-03-02 milestone Mar 17, 2020
@ciyer ciyer modified the milestones: sprint-2020-03-02, 0.9.0 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Environments] Add info about requested resources
3 participants