-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metabolite drug factor calculation to match AS and AR conversion model unittests. #134
Comments
@KatherineKay For later reference. |
Tobi, was this trying to account for differences to Katherine's code? If so it would be useful to be able to reproduce her results. |
Issue is being worked on in this branch. One issue with incorrect drug concentration has been fixed, but some other errors remain (mostly to do with drug factors). |
Most PK/PD tests have been checked, all updated to use plenty of precision. As noted in the last commit, the only significant source of errors is the drug factors in the AS-DHA conversion test. |
Drug factor differences have been identified as slight methodological differences, as documented here. We decided the 5-10% difference (only 10% for survival rates under 1 in 10^9) is not that significant for our usage. |
See https://github.com/SwissTPH/openmalaria/blob/develop/model/PkPd/Drug/LSTMDrugConversion.cpp#L114
The text was updated successfully, but these errors were encountered: