fix verifyingContract to be a valid evm hex address (using cosmos as hex address)
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaMask (currently only the extension) has added a new validation that requires the verifyingContract field in the EIP-712 JSON to be a valid EVM address. This change is causing issues because our verifyingContract is set to 'cosmos', preventing users from submitting transactions on Carbon via MetaMask.
To resolve this, we need to update verifyingContract to any valid hex address, but this will require a backend upgrade.
below is an issue created by another team which is facing the same issue:
MetaMask/metamask-extension#26980
this is prob the quickest fix cos not sure when metamask team will update
the hex address can be anything, just need to follow the spec.
relevant portion of the code in metamask extension source code:
Edit: We have decided to go ahead with the hex representation of 'comsos' as the hex address