Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price values are wrong in the PDF invoice #306

Closed
artyuum opened this issue Apr 26, 2023 · 3 comments
Closed

Price values are wrong in the PDF invoice #306

artyuum opened this issue Apr 26, 2023 · 3 comments

Comments

@artyuum
Copy link

artyuum commented Apr 26, 2023

The tax in my shop is configured to be included in the price and I'm programmatically creating the product by providing the price (that includes the tax). However, in the PDF generated, the values regarding the price don't make sense:
image

TTC = price including tax
HT = price without
As you can see, "Prix HT" is higher than "Prix TTC unitaire" which is not normal. Same for "Total TTC" that should be "80 €".

While in the backoffice, the values are correct:
image

My temporary fix was to override the pdf.html.twig template and copy/paste the html from @SyliusAdmin/Order/Show/_summary.html.twig (with some adjustments regarding the css classes, etc.) and now the data in the PDF is correct:
image

@diimpp
Copy link
Member

diimpp commented Jul 8, 2023

Invoice is merely represents all taxes as excluded from price, which doesn't make price values incorrect.

If there is some legal case, where invoice must contain taxes included in price, please present it.

@TalkMarc
Copy link

TalkMarc commented Dec 6, 2023

Having a configuration option to include taxes in unit prices would be a nice feature.
Here in Switzerland it's very common to include taxes in all listed Prices.
Maybe having the option to display both a unit net price excluding taxes, and a unit price including taxes would be a good compromise.

GSadee added a commit that referenced this issue Apr 23, 2024
This PR was merged into the main branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | main             |
| Bug fix?        | yes                                                       |
| New feature?    | no                                                    |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets |        #306            |
| License         | MIT                                                          |

Fix this issue : 
- #306

Inversion between gross value and net value in french translation. 


Commits
-------

26fde47 [Translation] fix french transalation
@GSadee
Copy link
Member

GSadee commented Apr 23, 2024

Should be fixed by #307

@GSadee GSadee closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants