Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): loosen constraint for symfony/messenger #165

Merged
merged 2 commits into from
Dec 6, 2019
Merged

fix(deps): loosen constraint for symfony/messenger #165

merged 2 commits into from
Dec 6, 2019

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Nov 23, 2019

Like Sylius/ShopApiPlugin#602: allow upgrade to symfony 4.4

@Gounlaf Gounlaf requested a review from a team as a code owner November 23, 2019 18:21
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Florian,

thanks for the contribution! Could you take a look into failing build?

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Nov 25, 2019

Hello Florian,

thanks for the contribution! Could you take a look into failing build?

Well, I can fix it if you want, but it's not related to this PR...

It's related to release 4.4.
IMO implemented method (execute) shouldn't have a return type (even if required php version is >= 7.2) to respect contract/parent method.
Another PR should be done to fix it;

@pamil
Copy link
Contributor

pamil commented Nov 27, 2019

There are BC breaks between Messenger 4.3 and 4.4, it might be worth to review them: https://github.com/symfony/symfony/blob/master/UPGRADE-4.4.md#messenger

@pamil pamil merged commit a12d0ff into Sylius:master Dec 6, 2019
@pamil
Copy link
Contributor

pamil commented Dec 6, 2019

Thanks, Florian! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants