Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade file fixes #350

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Upgrade file fixes #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 32 additions & 31 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,10 @@
+ class: "%sylius.model.channel.class%"
# ...
```

1. Service and Alias Refactoring for [New Naming Convention](https://github.com/Sylius/Sylius/blob/2.0/adr/2024_10_03_services_naming_convention.md)
Including the following changes:

#### Configuration root key change:
1. The naming has been unified throughout the plugin, encompassing the following changes:

#### Configuration root key change

```diff
- sylius_invoicing_plugin:
Expand All @@ -129,13 +128,39 @@
|---------------------------------|--------------------------|
| sylius_invoicing_plugin_invoice | sylius_invoicing_invoice |

#### Changed Parameters

| Old | New |
|------------------------------------------------------------|-----------------------------------------------------|
| sylius_invoicing_plugin.controller.billing_data.class | sylius_invoicing.controller.billing_data.class |
| sylius_invoicing_plugin.controller.invoice.class | sylius_invoicing.controller.invoice.class |
| sylius_invoicing_plugin.controller.invoice_sequence.class | sylius_invoicing.controller.invoice_sequence.class |
| sylius_invoicing_plugin.controller.line_item.class | sylius_invoicing.controller.line_item.class |
| sylius_invoicing_plugin.controller.shop_billing_data.class | sylius_invoicing.controller.shop_billing_data.class |
| sylius_invoicing_plugin.controller.tax_item.class | sylius_invoicing.controller.tax_item.class |
| sylius_invoicing_plugin.factory.billing_data.class | sylius_invoicing.factory.billing_data.class |
| sylius_invoicing_plugin.factory.invoice.class | sylius_invoicing.factory.invoice.class |
| sylius_invoicing_plugin.factory.invoice_sequence.class | sylius_invoicing.factory.invoice_sequence.class |
| sylius_invoicing_plugin.factory.line_item.class | sylius_invoicing.factory.line_item.class |
| sylius_invoicing_plugin.factory.shop_billing_data.class | sylius_invoicing.factory.shop_billing_data.class |
| sylius_invoicing_plugin.factory.tax_item.class | sylius_invoicing.factory.tax_item.class |
| sylius_invoicing_plugin.model.billing_data.class | sylius_invoicing.model.billing_data.class |
| sylius_invoicing_plugin.model.invoice.class | sylius_invoicing.model.invoice.class |
| sylius_invoicing_plugin.model.invoice_sequence.class | sylius_invoicing.model.invoice_sequence.class |
| sylius_invoicing_plugin.model.line_item.class | sylius_invoicing.model.line_item.class |
| sylius_invoicing_plugin.model.shop_billing_data.class | sylius_invoicing.model.shop_billing_data.class |
| sylius_invoicing_plugin.model.tax_item.class | sylius_invoicing.model.tax_item.class |
| sylius_invoicing_plugin.repository.invoice.class | sylius_invoicing.repository.invoice.class |

1. Services have been refactored to align with the [New Naming Convention](https://github.com/Sylius/Sylius/blob/2.0/adr/2024_10_03_services_naming_convention.md):

#### Changed Services

| Old id | New id |
|------------------------------------------------------------------------------------|-----------------------------------------------------------------------------|
| sylius_invoicing_plugin.event_listener.workflow.payment.produce_order_payment_paid | sylius_invoicing.event_listener.workflow.payment.produce_order_payment_paid |
| sylius_invoicing_plugin.ui.action.download_invoice | sylius_invoicing.controller.download_invoice |
| sylius_invoicing_plugin.ui.action.resend_invoice | sylius_invoicing.controller.resend_invoice |
| sylius_invoicing_plugin.ui.action.download_invoice | sylius_invoicing.controller.download_invoice |
| sylius_invoicing_plugin.ui.action.resend_invoice | sylius_invoicing.controller.resend_invoice |
| sylius_invoicing_plugin.cli.generate_invoices | sylius_invoicing.cli.generate_invoices |
| sylius_invoicing_plugin.converter.order_item_units_to_line_items | sylius_invoicing.converter.order_item_units_to_line_items |
| sylius_invoicing_plugin.converter.shipping_adjustments_to_line_items | sylius_invoicing.converter.shipping_adjustments_to_line_items |
Expand All @@ -159,7 +184,7 @@
| sylius_invoicing_plugin.event_listener.order_placed | sylius_invoicing.listener.order_placed |
| sylius_invoicing_plugin.event_producer.order_placed | sylius_invoicing.event_producer.order_placed |
| sylius_invoicing_plugin.listener.order_payment_paid | sylius_invoicing.listener.order_payment_paid |
| sylius_invoicing_plugin.ui.menu.admin_menu_listener | sylius_invoicing.listener.admin_menu |
| sylius_invoicing_plugin.ui.menu.admin_menu_listener | sylius_invoicing.listener.admin_menu |
| sylius_invoicing_plugin.email.invoice_email_sender | sylius_invoicing.email.invoice_email_sender |
| sylius_invoicing_plugin.command_handler.send_invoice_email | sylius_invoicing.command_handler.send_invoice_email |
| sylius_invoicing_plugin.provider.tax_rate_percentage | sylius_invoicing.provider.tax_rate_percentage |
Expand Down Expand Up @@ -196,30 +221,6 @@
| sylius_invoicing_plugin.controller_state_machine.tax_item | sylius_invoicing.controller_state_machine.tax_item |
| sylius_invoicing_plugin.controller_state_machine.invoice_sequence | sylius_invoicing.controller_state_machine.invoice_sequence |

#### Changed Parameters

| Old | New |
|------------------------------------------------------------|-----------------------------------------------------|
| sylius_invoicing_plugin.controller.billing_data.class | sylius_invoicing.controller.billing_data.class |
| sylius_invoicing_plugin.controller.invoice.class | sylius_invoicing.controller.invoice.class |
| sylius_invoicing_plugin.controller.invoice_sequence.class | sylius_invoicing.controller.invoice_sequence.class |
| sylius_invoicing_plugin.controller.line_item.class | sylius_invoicing.controller.line_item.class |
| sylius_invoicing_plugin.controller.shop_billing_data.class | sylius_invoicing.controller.shop_billing_data.class |
| sylius_invoicing_plugin.controller.tax_item.class | sylius_invoicing.controller.tax_item.class |
| sylius_invoicing_plugin.factory.billing_data.class | sylius_invoicing.factory.billing_data.class |
| sylius_invoicing_plugin.factory.invoice.class | sylius_invoicing.factory.invoice.class |
| sylius_invoicing_plugin.factory.invoice_sequence.class | sylius_invoicing.factory.invoice_sequence.class |
| sylius_invoicing_plugin.factory.line_item.class | sylius_invoicing.factory.line_item.class |
| sylius_invoicing_plugin.factory.shop_billing_data.class | sylius_invoicing.factory.shop_billing_data.class |
| sylius_invoicing_plugin.factory.tax_item.class | sylius_invoicing.factory.tax_item.class |
| sylius_invoicing_plugin.model.billing_data.class | sylius_invoicing.model.billing_data.class |
| sylius_invoicing_plugin.model.invoice.class | sylius_invoicing.model.invoice.class |
| sylius_invoicing_plugin.model.invoice_sequence.class | sylius_invoicing.model.invoice_sequence.class |
| sylius_invoicing_plugin.model.line_item.class | sylius_invoicing.model.line_item.class |
| sylius_invoicing_plugin.model.shop_billing_data.class | sylius_invoicing.model.shop_billing_data.class |
| sylius_invoicing_plugin.model.tax_item.class | sylius_invoicing.model.tax_item.class |
| sylius_invoicing_plugin.repository.invoice.class | sylius_invoicing.repository.invoice.class |

1. Doctrine migrations have been regenerated, meaning all previous migration files have been removed and their content is now in a single migration file.
To apply the new migration and get rid of the old entries run migrations as usual:

Expand Down