Fixes after PR review

UPGRADE.md

@@ -7,6 +7,9 @@
 * The views have been moved to the appropriate directories depending on the context.
     * This might require changing the serializer settings in your application
 * Tactician has been replaced with Symfony Messenger.
+    * Used `League\Tactician\CommandBus` has been replaced with `Symfony\Component\Messenger\MessageBusInterface`
+    * The commands are now dispatched using `dispatch()` method instead of `handle()`
+    * The method name in handlers has been changed from `handle()` to `__invoke()`
 
 # UPGRADE FROM 1.0.0-beta.17 to 1.0.0-beta.18
 

spec/EventListener/UserRegistrationListenerSpec.php

@@ -6,12 +6,10 @@
 
 use Doctrine\Common\Persistence\ObjectManager;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Sylius\Component\Channel\Repository\ChannelRepositoryInterface;
 use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\ShopUserInterface;
 use Sylius\Component\User\Repository\UserRepositoryInterface;
-use Sylius\ShopApiPlugin\Command\Cart\PickupCart;
 use Sylius\ShopApiPlugin\Command\Customer\GenerateVerificationToken;
 use Sylius\ShopApiPlugin\Command\Customer\SendVerificationToken;
 use Sylius\ShopApiPlugin\Event\CustomerRegistered;
@@ -41,26 +39,9 @@ function it_generates_and_sends_verification_token_if_channel_requires_verificat
         $firstCommand = new GenerateVerificationToken('shop@example.com');
         $bus->dispatch($firstCommand)->willReturn(new Envelope($firstCommand))->shouldBeCalled();
 
-        $bus
-            ->dispatch(Argument::that(function (PickupCart $pickupCart): bool {
-                return !empty($pickupCart->orderToken()) && $pickupCart->channelCode() === 'en_GB';
-            }))
-            ->willReturn(new Envelope(new \stdClass()))
-            ->shouldBeCalled()
-        ;
-
-
         $secondCommand = new SendVerificationToken('shop@example.com', 'WEB_GB');
         $bus->dispatch($secondCommand)->willReturn(new Envelope($secondCommand))->shouldBeCalled();
 
-        $bus
-            ->dispatch(Argument::that(function (PickupCart $pickupCart): bool {
-                return !empty($pickupCart->orderToken()) && $pickupCart->channelCode() === 'en_GB';
-            }))
-            ->willReturn(new Envelope(new \stdClass()))
-            ->shouldBeCalled()
-        ;
-
         $this->handleUserVerification(new CustomerRegistered(
             'shop@example.com',
             'Shop',

spec/Normalizer/RequestCartTokenNormalizerSpec.php

@@ -74,8 +74,8 @@ function it_picks_up_new_cart_and_sets_its_token_on_request_if_token_was_not_pas
         $validator->validate(Argument::type(PickupCartRequest::class))->willReturn($constraintViolationList);
 
         $bus
-            ->dispatch(Argument::that(function (PickupCart $pickupCart): bool {
-                return !empty($pickupCart->orderToken()) && $pickupCart->channelCode() === 'en_GB';
+            ->dispatch(Argument::that(function (PickupCart $command): bool {
+                return !empty($command->orderToken()) && $command->channelCode() === 'en_GB';
             }))
             ->willReturn(new Envelope(new \stdClass()))
             ->shouldBeCalled()