Merge pull request #218 from pamil/coding-standard

Coding standard
Sylius · Sep 28, 2017 · b82a5ac · b82a5ac
2 parents 64ac2c5 + f89641f
commit b82a5ac
Show file tree

Hide file tree

Showing 308 changed files with 614 additions and 306 deletions.
diff --git a/composer.json b/composer.json
@@ -17,7 +17,9 @@
         "matthiasnoback/symfony-config-test": "^2.0",
         "matthiasnoback/symfony-dependency-injection-test": "^1.0",
         "phpunit/phpunit": "^5.6",
-        "doctrine/common": "<2.8"
+        "doctrine/common": "<2.8",
+        "symplify/easy-coding-standard": "^2.4",
+        "sylius-labs/coding-standard": "^1.0"
     },
     "autoload": {
         "psr-4": {

diff --git a/easy-coding-standard.neon b/easy-coding-standard.neon
@@ -0,0 +1,2 @@
+includes:
+    - vendor/sylius-labs/coding-standard/easy-coding-standard.neon
diff --git a/spec/Checker/PromotionCouponEligibilityCheckerSpec.php b/spec/Checker/PromotionCouponEligibilityCheckerSpec.php
@@ -1,16 +1,16 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Checker;
 
+use PhpSpec\ObjectBehavior;
 use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\OrderInterface;
 use Sylius\Component\Core\Model\PromotionCouponInterface;
 use Sylius\Component\Core\Model\PromotionInterface;
 use Sylius\Component\Promotion\Checker\Eligibility\PromotionCouponEligibilityCheckerInterface;
 use Sylius\Component\Promotion\Checker\Eligibility\PromotionEligibilityCheckerInterface;
-use Sylius\ShopApiPlugin\Checker\PromotionCouponEligibilityChecker;
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 final class PromotionCouponEligibilityCheckerSpec extends ObjectBehavior
 {

diff --git a/spec/Command/AddCouponSpec.php b/spec/Command/AddCouponSpec.php
@@ -1,10 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\AddCoupon;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 final class AddCouponSpec extends ObjectBehavior
 {

diff --git a/spec/Command/AddProductReviewByCodeSpec.php b/spec/Command/AddProductReviewByCodeSpec.php
@@ -1,11 +1,10 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 final class AddProductReviewByCodeSpec extends ObjectBehavior
 {

diff --git a/spec/Command/AddProductReviewBySlugSpec.php b/spec/Command/AddProductReviewBySlugSpec.php
@@ -1,11 +1,10 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 final class AddProductReviewBySlugSpec extends ObjectBehavior
 {

diff --git a/spec/Command/AddressOrderSpec.php b/spec/Command/AddressOrderSpec.php
@@ -1,11 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\AddressCart;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
-use Sylius\ShopApiPlugin\Command\AddressOrder;
 use Sylius\ShopApiPlugin\Model\Address;
 
 final class AddressOrderSpec extends ObjectBehavior

diff --git a/spec/Command/ChangeItemQuantitySpec.php b/spec/Command/ChangeItemQuantitySpec.php
@@ -1,8 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\ChangeItemQuantity;
 use PhpSpec\ObjectBehavior;
 
 final class ChangeItemQuantitySpec extends ObjectBehavior

diff --git a/spec/Command/ChoosePaymentMethodSpec.php b/spec/Command/ChoosePaymentMethodSpec.php
@@ -1,8 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\ChoosePaymentMethod;
 use PhpSpec\ObjectBehavior;
 
 final class ChoosePaymentMethodSpec extends ObjectBehavior

diff --git a/spec/Command/ChooseShippingMethodSpec.php b/spec/Command/ChooseShippingMethodSpec.php
@@ -1,8 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\ChooseShippingMethod;
 use PhpSpec\ObjectBehavior;
 
 final class ChooseShippingMethodSpec extends ObjectBehavior

diff --git a/spec/Command/CompleteOrderSpec.php b/spec/Command/CompleteOrderSpec.php
@@ -1,9 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\ShopApiPlugin\Command\CompleteOrder;
 
 final class CompleteOrderSpec extends ObjectBehavior
 {

diff --git a/spec/Command/DropCartSpec.php b/spec/Command/DropCartSpec.php
@@ -1,9 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\ShopApiPlugin\Command\DropCart;
 
 final class DropCartSpec extends ObjectBehavior
 {

diff --git a/spec/Command/GenerateResetPasswordTokenSpec.php b/spec/Command/GenerateResetPasswordTokenSpec.php
@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 

diff --git a/spec/Command/GenerateVerificationTokenSpec.php b/spec/Command/GenerateVerificationTokenSpec.php
@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 

diff --git a/spec/Command/PickupCartSpec.php b/spec/Command/PickupCartSpec.php
@@ -1,8 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\PickupCart;
 use PhpSpec\ObjectBehavior;
 
 final class PickupCartSpec extends ObjectBehavior

diff --git a/spec/Command/PutOptionBasedConfigurableItemToCartSpec.php b/spec/Command/PutOptionBasedConfigurableItemToCartSpec.php
@@ -1,9 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\ShopApiPlugin\Command\PutOptionBasedConfigurableItemToCart;
 
 final class PutOptionBasedConfigurableItemToCartSpec extends ObjectBehavior
 {

diff --git a/spec/Command/PutSimpleItemToCartSpec.php b/spec/Command/PutSimpleItemToCartSpec.php
@@ -1,8 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
-use Sylius\ShopApiPlugin\Command\PutSimpleItemToCart;
 use PhpSpec\ObjectBehavior;
 
 final class PutSimpleItemToCartSpec extends ObjectBehavior

diff --git a/spec/Command/PutVariantBasedConfigurableItemToCartSpec.php b/spec/Command/PutVariantBasedConfigurableItemToCartSpec.php
@@ -1,9 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Command;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\ShopApiPlugin\Command\PutVariantBasedConfigurableItemToCart;
 
 final class PutVariantBasedConfigurableItemToCartSpec extends ObjectBehavior
 {

diff --git a/spec/Command/SendResetPasswordTokenSpec.php b/spec/Command/SendResetPasswordTokenSpec.php
@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 

diff --git a/spec/Command/SendVerificationTokenSpec.php b/spec/Command/SendVerificationTokenSpec.php
@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 

diff --git a/spec/Command/VerifyAccountSpec.php b/spec/Command/VerifyAccountSpec.php
@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\Command;
 

diff --git a/spec/EventListener/RequestLocaleSetterSpec.php b/spec/EventListener/RequestLocaleSetterSpec.php
@@ -1,11 +1,10 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\EventListener;
 
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Sylius\Component\Locale\Provider\LocaleProviderInterface;
 use Sylius\ShopApiPlugin\EventListener\RequestLocaleSetter;
 use Symfony\Component\HttpFoundation\Request;

diff --git a/spec/EventListener/UserRegistrationListenerSpec.php b/spec/EventListener/UserRegistrationListenerSpec.php
@@ -1,21 +1,19 @@
 <?php
 
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace spec\Sylius\ShopApiPlugin\EventListener;
 
 use Doctrine\Common\Persistence\ObjectManager;
 use League\Tactician\CommandBus;
+use PhpSpec\ObjectBehavior;
 use Sylius\Component\Channel\Repository\ChannelRepositoryInterface;
 use Sylius\Component\Core\Model\ChannelInterface;
-use Sylius\Component\Core\Model\CustomerInterface;
 use Sylius\Component\Core\Model\ShopUserInterface;
 use Sylius\Component\User\Repository\UserRepositoryInterface;
 use Sylius\ShopApiPlugin\Command\GenerateVerificationToken;
 use Sylius\ShopApiPlugin\Command\SendVerificationToken;
 use Sylius\ShopApiPlugin\Event\CustomerRegistered;
-use PhpSpec\ObjectBehavior;
-use Symfony\Component\EventDispatcher\GenericEvent;
 
 final class UserRegistrationListenerSpec extends ObjectBehavior
 {

diff --git a/spec/Factory/AddressViewFactorySpec.php b/spec/Factory/AddressViewFactorySpec.php
@@ -1,10 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
-use Sylius\Component\Core\Model\AddressInterface;
-use Sylius\ShopApiPlugin\Factory\AddressViewFactory;
 use PhpSpec\ObjectBehavior;
+use Sylius\Component\Core\Model\AddressInterface;
 use Sylius\ShopApiPlugin\Factory\AddressViewFactoryInterface;
 use Sylius\ShopApiPlugin\View\AddressView;
 

diff --git a/spec/Factory/AdjustmentViewFactorySpec.php b/spec/Factory/AdjustmentViewFactorySpec.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
 use PhpSpec\ObjectBehavior;

diff --git a/spec/Factory/CartItemViewFactorySpec.php b/spec/Factory/CartItemViewFactorySpec.php
@@ -1,14 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
+use PhpSpec\ObjectBehavior;
 use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\OrderItemInterface;
 use Sylius\Component\Core\Model\ProductInterface;
 use Sylius\Component\Core\Model\ProductVariantInterface;
-use Sylius\ShopApiPlugin\Factory\CartItemViewFactory;
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Sylius\ShopApiPlugin\Factory\CartItemViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\ProductVariantViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\ProductViewFactoryInterface;
@@ -44,7 +44,7 @@ function it_builds_cart_item_view(
         $cartItem->getProduct()->willReturn($tshirt);
         $cartItem->getVariant()->willReturn($tshirtVariant);
 
-        $productViewFactory->create($tshirt, $channel,'en_GB')->willReturn(new ProductView());
+        $productViewFactory->create($tshirt, $channel, 'en_GB')->willReturn(new ProductView());
 
         $productVariantViewFactory->create($tshirtVariant, $channel, 'en_GB')->willReturn(new ProductVariantView());
 

diff --git a/spec/Factory/CartViewFactorySpec.php b/spec/Factory/CartViewFactorySpec.php
@@ -1,8 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
 use Doctrine\Common\Collections\ArrayCollection;
+use PhpSpec\ObjectBehavior;
 use Sylius\Component\Core\Model\AddressInterface;
 use Sylius\Component\Core\Model\AdjustmentInterface;
 use Sylius\Component\Core\Model\ChannelInterface;
@@ -13,15 +16,14 @@
 use Sylius\ShopApiPlugin\Factory\AddressViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\AdjustmentViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\CartItemViewFactoryInterface;
-use PhpSpec\ObjectBehavior;
 use Sylius\ShopApiPlugin\Factory\CartViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\PaymentViewFactoryInterface;
+use Sylius\ShopApiPlugin\Factory\ShipmentViewFactoryInterface;
 use Sylius\ShopApiPlugin\Factory\TotalViewFactoryInterface;
 use Sylius\ShopApiPlugin\View\AddressView;
 use Sylius\ShopApiPlugin\View\AdjustmentView;
 use Sylius\ShopApiPlugin\View\CartSummaryView;
 use Sylius\ShopApiPlugin\View\ItemView;
-use Sylius\ShopApiPlugin\Factory\ShipmentViewFactoryInterface;
 use Sylius\ShopApiPlugin\View\PaymentView;
 use Sylius\ShopApiPlugin\View\ShipmentView;
 use Sylius\ShopApiPlugin\View\TotalsView;

diff --git a/spec/Factory/DetailedProductViewFactorySpec.php b/spec/Factory/DetailedProductViewFactorySpec.php
@@ -1,21 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
+use PhpSpec\ObjectBehavior;
 use Sylius\Component\Core\Model\ChannelInterface;
-use Sylius\Component\Core\Model\ProductImageInterface;
 use Sylius\Component\Core\Model\ProductInterface;
-use Sylius\Component\Core\Model\ProductVariantInterface;
-use Sylius\Component\Product\Model\ProductAssociationInterface;
-use Sylius\Component\Product\Model\ProductAssociationTypeInterface;
-use Sylius\ShopApiPlugin\Factory\DetailedProductViewFactory;
-use Sylius\ShopApiPlugin\Factory\ImageViewFactoryInterface;
-use Sylius\ShopApiPlugin\Factory\ProductVariantViewFactoryInterface;
-use PhpSpec\ObjectBehavior;
 use Sylius\ShopApiPlugin\Factory\ProductViewFactoryInterface;
 use Sylius\ShopApiPlugin\Generator\ProductBreadcrumbGeneratorInterface;
-use Sylius\ShopApiPlugin\View\ImageView;
-use Sylius\ShopApiPlugin\View\ProductVariantView;
 use Sylius\ShopApiPlugin\View\ProductView;
 
 final class DetailedProductViewFactorySpec extends ObjectBehavior

diff --git a/spec/Factory/ImageViewFactorySpec.php b/spec/Factory/ImageViewFactorySpec.php
@@ -1,12 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace spec\Sylius\ShopApiPlugin\Factory;
 
-use Liip\ImagineBundle\Imagine\Cache\CacheManager;
-use Sylius\Component\Core\Model\ImageInterface;
-use Sylius\ShopApiPlugin\Factory\ImageViewFactory;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
+use Sylius\Component\Core\Model\ImageInterface;
 use Sylius\ShopApiPlugin\Factory\ImageViewFactoryInterface;
 use Sylius\ShopApiPlugin\View\ImageView;