Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cartSummarize allows access to all orders #438

Closed
dlobato opened this issue Apr 30, 2019 · 0 comments · Fixed by #439
Closed

cartSummarize allows access to all orders #438

dlobato opened this issue Apr 30, 2019 · 0 comments · Fixed by #439

Comments

@dlobato
Copy link
Contributor

dlobato commented Apr 30, 2019

cartSummarize endpoint (/{channelCode}/carts/{token} get) allows to access any order regardless of state. It should only allow to access orders in cart state.

cartSummarize_response.json.zip is a response to a random order created by fixtures data to the endpoint:
GET http://127.0.0.1:8000/shop-api/US_WEB/carts/pcBfQSkq8t
@dlobato dlobato mentioned this issue Apr 30, 2019
Closed
@mamazu mamazu mentioned this issue Apr 30, 2019
Merged
lchrusciel added a commit that referenced this issue May 10, 2019
@lchrusciel
bug #439 Cart summary now only works for orders in state cart (mamazu…
e0cc50c 
…, lchrusciel)

This PR was merged into the 1.0-dev branch.

Discussion
----------

- Also added local phpunit config to the `.gitignore`
Closes #438 

Commits
-------

86aeaa9 Adding a test for preventing regression
8d8cfb4 Fixing the tests
44b274f Fixed tests again
d2d98ac Fixing the cart query
7192eb4 Removing repository test
3e63a4d Fixed coding style
3f1d3a2 Implementing the suggestions from @GSadee
f44c1e5 Fixing fixtures
1cc6ac6 Adding tests back in
0e445e4 [Tests] Fix placed order creation in test env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cart summary now only works for orders in state cart mamazu/ShopApiPlugin
1 participant
@dlobato