Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error when registering with exist email address #533

Closed
alexander-schranz opened this issue Sep 11, 2019 · 3 comments · Fixed by #546
Closed

500 error when registering with exist email address #533

alexander-schranz opened this issue Sep 11, 2019 · 3 comments · Fixed by #546
Labels

Comments

@alexander-schranz
Copy link
Contributor

When registering with exist email address it should return a 400 status code and not a server side error.

@mamazu
Copy link
Member

mamazu commented Sep 11, 2019

There is a validation for it. Can you check why the ShopUserDoesNotExistValidator doesn't add a violation to the list?

@adrianmarte
Copy link
Contributor

@alexander-schranz I can not reproduce this issue:

{
    "code": 400,
    "message": "Validation failed",
    "errors": {
        "email": [
            "This email is already used."
        ]
    }
}

HTTP Status Code is also "400 Bad Request"

@mamazu
Copy link
Member

mamazu commented Sep 21, 2019

Sounds like it works as it is supposed to. Please provide a test case where it fails.

@mamazu mamazu added More info needed More information on the topic is neeeded. Unconfirmed Bug and removed Bug Minor labels Sep 21, 2019
@lchrusciel lchrusciel added Bug and removed More info needed More information on the topic is neeeded. Unconfirmed Bug labels Sep 22, 2019
mamazu added a commit that referenced this issue Sep 22, 2019
…chrusciel)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Closes #533

This would handle the registration process like Standard Sylius that a Customer is set to the User if the E-Mail Address exist as a customer. Currently you are not able to register if you did an anonymous order over the shop api.

Commits
-------

fd2951a Handle registration for exist customer
df65705 [Customer] Assert that customer can create an account even if they exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants