Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProductVariantView::$appliedPromotions #189

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Remove ProductVariantView::$appliedPromotions #189

merged 1 commit into from
Jul 17, 2017

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jul 14, 2017

No description provided.

@pamil pamil requested a review from lchrusciel July 14, 2017 13:41
@pamil pamil self-assigned this Jul 14, 2017
@pamil
Copy link
Contributor Author

pamil commented Jul 14, 2017

They're not used here and should be an exclusive part of UrbanaraCatalogPromotionPlugin.

@pamil pamil force-pushed the product-variant-adjustments branch from bcb28bc to 24a117f Compare July 14, 2017 14:49
@pamil pamil force-pushed the product-variant-adjustments branch from 24a117f to f1459dd Compare July 14, 2017 16:15
lchrusciel
lchrusciel approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. :)

@lchrusciel lchrusciel merged commit 5ce3937 into Sylius:master Jul 17, 2017
@lchrusciel
Copy link
Member

👍

@pamil pamil deleted the product-variant-adjustments branch July 17, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees

@pamil pamil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pamil @lchrusciel