Add latest products #237
Add latest products #237
Conversation
| return $this->viewHandler->handle(View::create($this->productLatestQuery->getLatestProducts( | ||
| $request->query->get('channel'), | ||
| $request->query->get('locale'), | ||
| (int) $request->query->get('limit', 4) |
| @@ -0,0 +1,5 @@ | |||
| shop_api_product_show_latest: | |||
| path: /product-latest/ | |||
There was a problem hiding this comment.
/products/latest/? WDYT? Not sure if it will not collide with some other route.
There was a problem hiding this comment.
I think there is a conflict with /shop-api/products/{code}, any other suggestions?
| use Sylius\ShopApiPlugin\View\ProductListView; | ||
| use Webmozart\Assert\Assert; | ||
|
|
||
| class ProductLatestViewRepository implements ProductLatestViewRepositoryInterface |
| private $productViewFactory; | ||
|
|
||
| /** | ||
| * ProductLatestViewRepository constructor. |
|
@sdleiw are you willing to apply this small changes? Just small things, but we can make them in one shot. Also, all the files are missing a blank line at the end of file(it is required due to cleaner github diffs) |
|
Hi @lchrusciel, thanks for the review, I'll take care of them, is there some kind of Code-Style that you use for the project, or just psr-2 |
|
We have. Mostly Symfony coding standard, PSR's, and our own clean code rules. All of them are put in https://github.com/SyliusLabs/CodingStandard. I just need to check to use them properly. |
|
Thanks Lei for contributing! :) |
ghost
deleted the
|
cool, had a lot of fun working on this repo |
|
I'm glad to hear that :) |
propose this PR to fetch latest products
the API looks like
/shop-api/product-latest/, with 3 parameterschannel,localeandlimit, wherechannelis required andlimitdefault value is 4, which matches the latest product counts on the demo shopdon't hesitate to leave comments on what's missing or inappropriate